Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest containerd version - v2.0.0 #33761

Conversation

dims
Copy link
Member

@dims dims commented Nov 5, 2024

New version is out! - https://github.com/containerd/containerd/releases/tag/v2.0.0

Let's switch some of the CI jobs we have to point to that version.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 5, 2024
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/jobs labels Nov 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 5, 2024
@kannon92
Copy link
Contributor

kannon92 commented Nov 5, 2024

Are we losing coverage for these jobs by promoting to 2.0? ie we lose 1.7 tests and gain the 2.0?

@kannon92
Copy link
Contributor

kannon92 commented Nov 5, 2024

#33761 (comment)

Otherwise I think this looks good.

I would probably think we need some sig-node related tests to change also as that would test more of the container runtime specifics.

@dims
Copy link
Member Author

dims commented Nov 5, 2024

@kannon92 we have plenty of other jobs that use 1.7, these specific ones we parameterized so we can kick the tires of new releases

@samuelkarp
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit ad4dc3d into kubernetes:master Nov 5, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@dims: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key gcp-gce.yaml using file config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml
  • key sig-network-misc.yaml using file config/jobs/kubernetes/sig-network/sig-network-misc.yaml
  • key sig-storage-gce-config.yaml using file config/jobs/kubernetes/sig-storage/sig-storage-gce-config.yaml

In response to this:

New version is out! - https://github.com/containerd/containerd/releases/tag/v2.0.0

Let's switch some of the CI jobs we have to point to that version.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants