Exporting KUBE_MASTER_OS_DISTRIBUTION for 1.3+ and KUBE_OS_DISTRIBUTION for 1.2 for GCI tests. #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ON for 1.2 for GCI tests.
| @@ -88,6 +88,7 @@ | |||
| export GINKGO_TEST_ARGS="--ginkgo.skip=\[Slow\]|\[Serial\]|\[Disruptive\]|\[Flaky\]|\[Feature:.+\]" | |||
| export GINKGO_PARALLEL="y" | |||
| export PROJECT="e2e-gce-gci-ci-master" | |||
| export KUBE_MASTER_OS_DISTRIBUTION="gci" | |||
There was a problem hiding this comment.
I believe KUBE_NODES_OS_DISTRIBUTION defaults to KUBE_MASTER_OS_DISTRIBUTION so we don't have to specify it here?
There was a problem hiding this comment.
Don't seem so. We may want to set KUBE_NODE_OS_DISTRIBUTION to gci too.
There was a problem hiding this comment.
Sorry, I thought we were only testing GCI masters. Added KUBE_NODE_OS_DISTRIBUTION as well.
|
Thanks for making the change. |
|
YAML looks fine to me. |
|
LGTM |
wonderfly
added
the
lgtm
mborsz
pushed a commit
to mborsz/test-infra
that referenced
this pull request
Dec 14, 2018
…isible_results ClusterLoader: Pretty printing test summary
grantr
pushed a commit
to grantr/test-infra
that referenced
this pull request
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@wonderfly @spxtr