Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new presubmit prow job for gcp-compute-persistent-disk-csi-driver to run e2e tests on NVMe VM target #32214

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add new presubmit prow job for gcp-compute-persistent-disk-csi-driver to run e2e tests on NVMe VM target #32214

wants to merge 1 commit into from

Conversation

pwschuurman
Copy link
Contributor

What type of PR is this?
/kind test

What this PR does / why we need it:
This adds support to run a subset of e2e tests in a configuration that uses NVMe devices on presubmit for the PDCSI Driver

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot
Copy link
Contributor

@pwschuurman: The label(s) kind/test cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?
/kind test

What this PR does / why we need it:
This adds support to run a subset of e2e tests in a configuration that uses NVMe devices on presubmit for the PDCSI Driver

Does this PR introduce a user-facing change?:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 8, 2024
@pwschuurman pwschuurman mentioned this pull request Mar 8, 2024
Merged
@k8s-ci-robot k8s-ci-robot requested a review from saad-ali March 8, 2024 20:22
@k8s-ci-robot k8s-ci-robot added the area/config Issues or PRs related to code in /config label Mar 8, 2024
@k8s-ci-robot k8s-ci-robot requested a review from saikat-royc March 8, 2024 20:22
@k8s-ci-robot k8s-ci-robot added area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 8, 2024
@pwschuurman
Copy link
Contributor Author

/hold This PR is dependent on kubernetes-sigs/gcp-compute-persistent-disk-csi-driver#1636 being checked in.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 8, 2024
@pwschuurman
Copy link
Contributor Author

/cc @Sneha-at

@k8s-ci-robot k8s-ci-robot requested a review from Sneha-at March 11, 2024 19:08
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 9, 2024
@pwschuurman
Copy link
Contributor Author

/assign @Sneha-at

@pwschuurman
Copy link
Contributor Author

/unhold kubernetes-sigs/gcp-compute-persistent-disk-csi-driver#1636 is merged

@pwschuurman
Copy link
Contributor Author

/assign @mattcary

@mattcary
Copy link
Contributor

mattcary commented Jul 9, 2024

/lgtm
/approve

I'm not sure what the upstream availability of NVMe devices is in our projects, but I guess we'll find out...

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattcary, pwschuurman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 8, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pwschuurman
Copy link
Contributor Author

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Oct 2, 2024
@k8s-ci-robot
Copy link
Contributor

@pwschuurman: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pwschuurman
Copy link
Contributor Author

/reopen

@k8s-ci-robot
Copy link
Contributor

@pwschuurman: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot reopened this Dec 7, 2024
@pwschuurman pwschuurman force-pushed the add-support-nvme-tests branch from adb2f87 to 6bea001 Compare December 7, 2024 00:59
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2024
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@pwschuurman pwschuurman force-pushed the add-support-nvme-tests branch 2 times, most recently from e1ee553 to 28806ef Compare December 7, 2024 01:21
@pwschuurman pwschuurman mentioned this pull request Dec 7, 2024
Open
@pwschuurman pwschuurman force-pushed the add-support-nvme-tests branch from 28806ef to d783725 Compare December 7, 2024 01:32
@pwschuurman
Copy link
Contributor Author

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Dec 9, 2024
@pwschuurman
Copy link
Contributor Author

/assign @saikat-royc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saad-ali saad-ali Awaiting requested review from saad-ali

@saikat-royc saikat-royc Awaiting requested review from saikat-royc

@Sneha-at Sneha-at Awaiting requested review from Sneha-at

Assignees

@mattcary mattcary

@saikat-royc saikat-royc

@Sneha-at Sneha-at

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pwschuurman @k8s-ci-robot @k8s-triage-robot @mattcary @saikat-royc @Sneha-at