Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AKS SDK to allow us to remove the final replace directive in our go.mod #30660

Merged
merged 4 commits into from
Sep 26, 2023

Conversation

cjwagner
Copy link
Member

@cjwagner cjwagner commented Sep 8, 2023

Follow up to #30651 to address #30651 (comment) separately

/assign @droslean

See golang/go#44840 (comment)
for why these are problematic for 'go install' and 'go get'.
I looked for a changelog describing when these lints were deprecated,
but I couldn't find anything. Other lints are still working so /shrug.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/ghproxy Issues or PRs related to code in /ghproxy area/kubetest area/prow Issues or PRs related to prow area/prow/plugins Issues or PRs related to prow's plugins for the hook component labels Sep 8, 2023
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Sep 8, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjwagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2023
@cjwagner cjwagner force-pushed the replace-replace-azure branch from bd9d399 to a4904e8 Compare September 8, 2023 18:11
@@ -2,28 +2,14 @@

module k8s.io/test-infra

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @airbornepony pointed out offline, it would be good to add a comment here saying "Please do not add a "replace" directive. See [LINK] for why they are bad for published packages." or similar.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I added some comments and also updated the dep.md doc.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/triage and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 8, 2023
@cjwagner
Copy link
Member Author

cjwagner commented Sep 8, 2023

@droslean Thanks for helping with the AKS SDK update! You can base your changes off this PR.

git checkout -b cjwagner-replace-replace-azure master
git pull [email protected]:cjwagner/test-infra.git replace-replace-azure

@k8s-ci-robot
Copy link
Contributor

@cjwagner: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-test-infra-unit-test 74046b2 link true /test pull-test-infra-unit-test
pull-test-infra-unit-test-race-detector-nonblocking 74046b2 link false /test pull-test-infra-unit-test-race-detector-nonblocking
pull-test-infra-verify-lint 74046b2 link true /test pull-test-infra-verify-lint

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit 74046b2 into kubernetes:master Sep 26, 2023
@cjwagner cjwagner deleted the replace-replace-azure branch January 10, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ghproxy Issues or PRs related to code in /ghproxy area/kubetest area/prow/plugins Issues or PRs related to prow's plugins for the hook component area/prow Issues or PRs related to prow area/triage cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants