-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AKS SDK to allow us to remove the final replace
directive in our go.mod
#30660
Update AKS SDK to allow us to remove the final replace
directive in our go.mod
#30660
Conversation
See golang/go#44840 (comment) for why these are problematic for 'go install' and 'go get'.
I looked for a changelog describing when these lints were deprecated, but I couldn't find anything. Other lints are still working so /shrug.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjwagner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
bd9d399
to
a4904e8
Compare
@@ -2,28 +2,14 @@ | |||
|
|||
module k8s.io/test-infra | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @airbornepony pointed out offline, it would be good to add a comment here saying "Please do not add a "replace" directive. See [LINK] for why they are bad for published packages." or similar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. I added some comments and also updated the dep.md doc.
@droslean Thanks for helping with the AKS SDK update! You can base your changes off this PR.
|
@cjwagner: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Follow up to #30651 to address #30651 (comment) separately
/assign @droslean