-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate cluster-api-provider-cloudstack jobs to eks-prow-build-cluster #29877
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrisdoherty4 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @rohityadavcloud @g-gaston @weizhouapache |
Hi @chrisdoherty4, the PR title says these are moving to |
@chrisdoherty4 |
370bdd1
to
9c215a0
Compare
@rjsadow Thank you, it should've been
@weizhouapache As noted in the OP, I refrained from touching that job as it integrates with an external system and the general advice is to avoid migrating those right now. |
@chrisdoherty4 |
/lgtm |
@chrisdoherty4: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks @weizhouapache, I'll raise another PR shortly. |
See #29722
This PR does not migrate the smoke test job as it creates clusters using an external CloudStack instance. The job is a trigger for an external system so its possible it'll work but we can deal with it separately.