Skip to content

feat(prow/plugins/approve): enhance the suggested approvers with hyperlinks#29762

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
ti-community-infra:feature/enhance-approvers-tips
Jun 21, 2023
Merged

feat(prow/plugins/approve): enhance the suggested approvers with hyperlinks#29762
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
ti-community-infra:feature/enhance-approvers-tips

Conversation

@wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Jun 11, 2023 •
edited
Loading

From "alice" to "alice". It highlights the approvers in the comment by hyperlink.

Signed-off-by: wuhuizuo wuhuizuo@126.com

@wuhuizuo
feat(prow/plugins/approve): enhance the suggested approvers with hype…
82396fd 
…rlinks

From `alice` to `[alice](https://github.com/alice)`. It highlights the approvers in the comment by hyperlink.

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/prow Issues or PRs related to prow labels Jun 11, 2023
@k8s-ci-robot k8s-ci-robot added area/prow/plugins Issues or PRs related to prow's plugins for the hook component sig/testing Categorizes an issue or PR as relevant to SIG Testing. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 11, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 11, 2023

Hi @wuhuizuo. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 11, 2023
@droslean
Copy link
Member

droslean commented Jun 12, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 12, 2023
petr-muller
petr-muller approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@petr-muller petr-muller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not I guess :) Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller, wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2023
@k8s-ci-robot k8s-ci-robot merged commit 2a6a094 into kubernetes:master Jun 21, 2023
@wuhuizuo wuhuizuo deleted the feature/enhance-approvers-tips branch June 26, 2023 07:03
wuhuizuo added a commit to PingCAP-QE/ee-ops that referenced this pull request Jun 29, 2023
@wuhuizuo
fix(apps/gc/prow/release): bump hook image tag to v20230629-a95a424
d567026 
Changes:
- kubernetes/test-infra#29762
- kubernetes/test-infra#29970
- other changes from upstream.

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@wuhuizuo wuhuizuo mentioned this pull request Jun 29, 2023
Merged
ti-chi-bot bot pushed a commit to PingCAP-QE/ee-ops that referenced this pull request Jun 29, 2023
@wuhuizuo
fix(apps/gc/prow/release): bump hook image tag to v20230629-a95a424 (…
0a8e5d6 
…#629)

Changes:
- kubernetes/test-infra#29762
- kubernetes/test-infra#29970
- other changes from upstream.

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjwagner cjwagner Awaiting requested review from cjwagner

@droslean droslean Awaiting requested review from droslean

1 more reviewer

@petr-muller petr-muller petr-muller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@petr-muller petr-muller

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow/plugins Issues or PRs related to prow's plugins for the hook component area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wuhuizuo @k8s-ci-robot @droslean @petr-muller

Comments