Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate kubernetes/node-feature-discovery jobs to eks cluster #29761

Merged

Conversation

iftachk
Copy link
Contributor

@iftachk iftachk commented Jun 11, 2023

jobs: migrate kubernetes/node-feature-discovery jobs to eks cluster

  • Add missing resource blocks
    /priority important-longterm
    /area jobs

Part of #29722

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config labels Jun 11, 2023
@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 11, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @iftachk. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rjsadow
Copy link
Contributor

rjsadow commented Jun 12, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 12, 2023
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iftachk for the patch.

Is there a reason to only convert some of the jobs and not all of them?

We also need to think about the resource requirements. Some of the jobs might want more than one cpu.

/cc @ArangoGutierrez

@iftachk
Copy link
Contributor Author

iftachk commented Jun 13, 2023

@marquiz Thank you for your feedback

Regarding the per-resource definitions, feel free to review the PR and let me know which jobs might need more resources.

For the reason why I only changed some jobs and not all - please review this issue|29722 which includes some specific details on which jobs needs to be migrated eg (kubernetes-sigs/node-feature-discovery | Prow Results | Search Results)

For any follow-up questions, I would recommend reaching out to sig-k8s-infra or sig-testing

Copy link
Contributor

@rjsadow rjsadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few jobs listed here that we wont be able to migrate quite yet.

@iftachk iftachk force-pushed the migrate-node-feature-discovery-job branch 2 times, most recently from 7fa3aed to b2b5acd Compare June 19, 2023 20:05
@ArangoGutierrez
Copy link
Contributor

Thanks @iftachk for the patch.

Is there a reason to only convert some of the jobs and not all of them?

We also need to think about the resource requirements. Some of the jobs might want more than one cpu.

/cc @ArangoGutierrez

Agree @iftachk NFD could crash with just 1 CPU, for the rest it looks ok to me

@iftachk iftachk force-pushed the migrate-node-feature-discovery-job branch from b2b5acd to 7f6ee2b Compare June 20, 2023 13:55
@iftachk
Copy link
Contributor Author

iftachk commented Jun 20, 2023

@ArangoGutierrez, as requested I've updated the resource blocks for the migrated NFD jobs
Would appreciate your feedback and approval in case it looks good to you.
Thanks,

@ArangoGutierrez
Copy link
Contributor

@ArangoGutierrez, as requested I've updated the resource blocks for the migrated NFD jobs Would appreciate your feedback and approval in case it looks good to you. Thanks,

going to test the full e2e run with the given resources and reply back shortly after

Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @iftachk. While you're at it, could you convert all presubmit jobs (not just the most recently run, or I don't know how you picked these ones) so that all jobs would be consistently run on the same cluster?

- Add missing resource blocks

Signed-off-by: Iftach Konshtok <[email protected]>
@iftachk iftachk force-pushed the migrate-node-feature-discovery-job branch from 7f6ee2b to 8bd8706 Compare June 22, 2023 13:23
@iftachk
Copy link
Contributor Author

iftachk commented Jun 22, 2023

/retest

@ameukam
Copy link
Member

ameukam commented Jul 1, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, iftachk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2023
@k8s-ci-robot k8s-ci-robot merged commit b3ad019 into kubernetes:master Jul 1, 2023
@k8s-ci-robot
Copy link
Contributor

@iftachk: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key node-feature-discovery-presubmits-generic.yaml using file config/jobs/kubernetes-sigs/node-feature-discovery/node-feature-discovery-presubmits-generic.yaml
  • key node-feature-discovery-presubmits-master.yaml using file config/jobs/kubernetes-sigs/node-feature-discovery/node-feature-discovery-presubmits-master.yaml

In response to this:

jobs: migrate kubernetes/node-feature-discovery jobs to eks cluster

  • Add missing resource blocks
    /priority important-longterm
    /area jobs

Part of #29722

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants