-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate kubernetes/node-feature-discovery jobs to eks cluster #29761
migrate kubernetes/node-feature-discovery jobs to eks cluster #29761
Conversation
Hi @iftachk. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @iftachk for the patch.
Is there a reason to only convert some of the jobs and not all of them?
We also need to think about the resource requirements. Some of the jobs might want more than one cpu.
/cc @ArangoGutierrez
@marquiz Thank you for your feedback Regarding the per-resource definitions, feel free to review the PR and let me know which jobs might need more resources. For the reason why I only changed some jobs and not all - please review this issue|29722 which includes some specific details on which jobs needs to be migrated eg (kubernetes-sigs/node-feature-discovery | Prow Results | Search Results) For any follow-up questions, I would recommend reaching out to sig-k8s-infra or sig-testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few jobs listed here that we wont be able to migrate quite yet.
config/jobs/kubernetes-sigs/node-feature-discovery/node-feature-discovery-postsubmits.yaml
Outdated
Show resolved
Hide resolved
config/jobs/kubernetes-sigs/node-feature-discovery/node-feature-discovery-postsubmits.yaml
Outdated
Show resolved
Hide resolved
...ig/jobs/kubernetes-sigs/node-feature-discovery/node-feature-discovery-presubmits-master.yaml
Outdated
Show resolved
Hide resolved
7fa3aed
to
b2b5acd
Compare
Agree @iftachk NFD could crash with just 1 CPU, for the rest it looks ok to me |
b2b5acd
to
7f6ee2b
Compare
@ArangoGutierrez, as requested I've updated the resource blocks for the migrated NFD jobs |
going to test the full e2e run with the given resources and reply back shortly after |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update @iftachk. While you're at it, could you convert all presubmit jobs (not just the most recently run, or I don't know how you picked these ones) so that all jobs would be consistently run on the same cluster?
...g/jobs/kubernetes-sigs/node-feature-discovery/node-feature-discovery-presubmits-generic.yaml
Outdated
Show resolved
Hide resolved
...g/jobs/kubernetes-sigs/node-feature-discovery/node-feature-discovery-presubmits-generic.yaml
Outdated
Show resolved
Hide resolved
- Add missing resource blocks Signed-off-by: Iftach Konshtok <[email protected]>
7f6ee2b
to
8bd8706
Compare
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam, iftachk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@iftachk: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
jobs: migrate kubernetes/node-feature-discovery jobs to eks cluster
/priority important-longterm
/area jobs
Part of #29722