Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run descheduler builds/checks on community cluster k8s-infra-prow-build #29008

Closed
wants to merge 1 commit into from
Closed

run descheduler builds/checks on community cluster k8s-infra-prow-build #29008

wants to merge 1 commit into from

Conversation

a7i
Copy link
Contributor

@a7i a7i commented Mar 13, 2023

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 13, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @a7i. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 13, 2023
@k8s-ci-robot k8s-ci-robot requested review from dims and wojtek-t March 13, 2023 14:04
damemi
damemi reviewed Mar 13, 2023
View reviewed changes
Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 13, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a7i, damemi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2023
@CecileRobertMichon CecileRobertMichon mentioned this pull request Mar 13, 2023
Closed
@BenTheElder
Copy link
Member

BenTheElder commented Mar 13, 2023 •
edited
Loading

#29003 (comment)

This cluster is primarily hosting sensitive github.com/Kubernetes/Kubernetes release blocking and PR blocking CI currently.

@BenTheElder
Copy link
Member

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2023
@BenTheElder
Copy link
Member

BenTheElder commented Mar 13, 2023 •
edited
Loading

Also, this PR won't merge anyhow because even test-infra is using the default cluster for cost reasons etc., so the PR tests on this PR will not work.

@a7i
Copy link
Contributor Author

a7i commented Mar 13, 2023

Thanks @BenTheElder

In that case, I'll go ahead and close the PR then.

/close

@k8s-ci-robot
Copy link
Contributor

@a7i: Closed this PR.

In response to this:

Thanks @BenTheElder

In that case, I'll go ahead and close the PR then.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@a7i a7i deleted the amir/descheduler-community-cluster branch March 13, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damemi damemi damemi left review comments

@dims dims Awaiting requested review from dims

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@a7i @k8s-ci-robot @BenTheElder @damemi