Skip to content

capo: only run PR-Blocking e2e tests in periodics and postsubmits#28221

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Nordix:lentzi90/capo-periodics-postsubmit-e2e-fix
Dec 12, 2022
Merged

capo: only run PR-Blocking e2e tests in periodics and postsubmits#28221
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Nordix:lentzi90/capo-periodics-postsubmit-e2e-fix

Conversation

@lentzi90
Copy link
Contributor

In #28082 I missed that we run the e2e tests as postsubmits and periodics also. It was never the intention to change the behavior of these tests, i.e. they should continue running only the PR-Blocking e2e tests.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 12, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @lentzi90. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 12, 2022
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 12, 2022
@tobiasgiese
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 12, 2022
@tobiasgiese
Copy link
Member

Thanks for fixing this! 👍🏻

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90, tobiasgiese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit 259a731 into kubernetes:master Dec 12, 2022
@k8s-ci-robot
Copy link
Contributor

@lentzi90: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-provider-openstack-periodics.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-openstack/cluster-api-provider-openstack-periodics.yaml
  • key cluster-api-provider-openstack-postsubmits.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-openstack/cluster-api-provider-openstack-postsubmits.yaml
Details

In response to this:

In #28082 I missed that we run the e2e tests as postsubmits and periodics also. It was never the intention to change the behavior of these tests, i.e. they should continue running only the PR-Blocking e2e tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lentzi90 lentzi90 deleted the lentzi90/capo-periodics-postsubmit-e2e-fix branch December 12, 2022 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants