Bazel build/test instructions are replaced with make rules#26039
Merged
k8s-ci-robot merged 3 commits intokubernetes:masterfrom Apr 20, 2022
Merged
Bazel build/test instructions are replaced with make rules#26039k8s-ci-robot merged 3 commits intokubernetes:masterfrom
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
area/robots
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
BenTheElder
approved these changes
Apr 20, 2022
Member
BenTheElder
left a comment
BenTheElder
left a comment
There was a problem hiding this comment.
/lgtm
/approve
Thanks Chao!
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, BenTheElder, chaodaiG, fejta The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
listx
pushed a commit
to listx/test-infra
that referenced
this pull request
Jun 14, 2022
This file used to be used by bazel. We don't use bazel any more and these tests are not run. However, since the time that bazel has been removed [1] [2], we have added additional integration tests that already use decorated jobs, which these deleted files test. [1]: ef78d78 [2]: kubernetes#26039
Merged
howardjohn
added a commit
to howardjohn/test-infra
that referenced
this pull request
Jun 23, 2022
istio-testing
pushed a commit
to istio/test-infra
that referenced
this pull request
Jun 27, 2022
kaalams
pushed a commit
to kaalams/test-infra
that referenced
this pull request
Jul 14, 2022
This file used to be used by bazel. We don't use bazel any more and these tests are not run. However, since the time that bazel has been removed [1] [2], we have added additional integration tests that already use decorated jobs, which these deleted files test. [1]: ef78d78 [2]: kubernetes#26039
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This repo has been built and tested without bazel for several months now, no obvious regression was seen, it's time to clean it up.
For code reviewers, this PR is broken down into 3 commits:
/cc @fejta @BenTheElder @cjwagner
cc @alvaroaleman @petr-muller