Crier slack reporter: use pointers for merging configs#22693
Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom Jul 1, 2021
Merged
Crier slack reporter: use pointers for merging configs#22693k8s-ci-robot merged 2 commits intokubernetes:masterfrom
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
Conversation
k8s-ci-robot
added
area/prow
chaodaiG
force-pushed
the
slack-override-from-job
branch
from
34989c2 to
0a6f12e
Compare
Contributor
Author
|
/cc @cjwagner @alvaroaleman |
cjwagner
reviewed
Jun 24, 2021
Member
cjwagner
left a comment
cjwagner
left a comment
There was a problem hiding this comment.
Thanks for fixing this up Chao, this seems much better than the previous config handling.
chaodaiG
force-pushed
the
slack-override-from-job
branch
from
0a6f12e to
72fb361
Compare
chaodaiG
commented
Jun 24, 2021
chaodaiG
force-pushed
the
slack-override-from-job
branch
from
72fb361 to
a2ee847
Compare
chaodaiG
force-pushed
the
slack-override-from-job
branch
from
a2ee847 to
09827e9
Compare
cjwagner
approved these changes
Jul 1, 2021
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chaodaiG, cjwagner The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
I don't think I have touched this test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes slack configuration using the same defaulting logic as other prow configurations. Will allow negating global slack configuration in job config.