images/gcb-docker-gcloud: enable docker-buildx builds#22599
images/gcb-docker-gcloud: enable docker-buildx builds#22599k8s-ci-robot merged 3 commits intokubernetes:masterfrom
Conversation
|
Hi @LorbusChris. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6025a19 to
d4156da
Compare
| @@ -7,8 +7,14 @@ steps: | |||
| - --build-arg=GO_VERSION=$_GO_VERSION | |||
| - . | |||
| dir: images/gcb-docker-gcloud/ | |||
There was a problem hiding this comment.
Is this intentional?
I had do use dir: . for the build to work with
builder --project=k8s-staging-test-infra --scratch-bucket=gs://k8s-staging-test-infra-gcb images/gcb-docker-gcloud/
There was a problem hiding this comment.
I think it doesn't need to be this way but may require changes I don't have time to dig into right now. Better to follow the same convention as everything else
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LorbusChris, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
These changes make the gcb-docker-gcloud image usable as a docker-buildx builder, like so (example from #22444):
/cc @spiffxp