Skip to content

Update snyk periodic job#22583

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
navidshaikh:pr/fix-snyk-job-2
Jun 16, 2021
Merged

Update snyk periodic job#22583
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
navidshaikh:pr/fix-snyk-job-2

Conversation

@navidshaikh
Copy link
Copy Markdown
Contributor

@navidshaikh navidshaikh commented Jun 16, 2021

  • quiet snyk download
  • check if SNYK_TOKEN envvar is present before running snyk
  • check if 'snyk test' command passed before filtering results
  • changed the interval to 1h to check if job is running correctly

/cc @dims @spiffxp

 - quiet snyk download
 - check if SNYK_TOKEN envvar is present before running snyk
 - check if 'snyk test' command passed before filtering results
@k8s-ci-robot k8s-ci-robot requested review from dims and spiffxp June 16, 2021 15:20
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 16, 2021
@navidshaikh
Copy link
Copy Markdown
Contributor Author

followup to #22570

@navidshaikh
Copy link
Copy Markdown
Contributor Author

changed the interval to 1h to check if job is running correctly, I'll revert it back to 6h once its green

@dims
Copy link
Copy Markdown
Member

dims commented Jun 16, 2021

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit 4408c92 into kubernetes:master Jun 16, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 16, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@navidshaikh: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key wg-k8s-infra-trusted.yaml using file config/jobs/kubernetes/wg-k8s-infra/trusted/wg-k8s-infra-trusted.yaml
Details

In response to this:

  • quiet snyk download
  • check if SNYK_TOKEN envvar is present before running snyk
  • check if 'snyk test' command passed before filtering results
  • changed the interval to 1h to check if job is running correctly

/cc @dims @spiffxp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@navidshaikh navidshaikh deleted the pr/fix-snyk-job-2 branch June 16, 2021 16:02
@navidshaikh
Copy link
Copy Markdown
Contributor Author

changed the interval to 1h to check if job is running correctly, I'll revert it back to 6h once its green

realised I didnt push the commit to change it to 1h, :-/
beside, the job failed again with

Invalid character in header content ["authorization"]

seems like this is due to special characters in the snyk token, I've updated the secrets with quote and that should be picked up for next run

adding a follow up to change the interval to 1h
cc: @dims

@dims
Copy link
Copy Markdown
Member

dims commented Jun 16, 2021

thanks @navidshaikh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants