Skip to content

Update Kube dependencies to v1.21 level#22477

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
alvaroaleman:update-0.9.0
Jun 8, 2021
Merged

Update Kube dependencies to v1.21 level#22477
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
alvaroaleman:update-0.9.0

Conversation

@alvaroaleman
Copy link
Copy Markdown
Member

@alvaroaleman alvaroaleman commented Jun 8, 2021

No specific reason other than hoping things will be somehow better :)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 8, 2021
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. area/prow Issues or PRs related to prow area/prow/plank Issues or PRs related to prow's plank component sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 8, 2021
alvaroaleman
alvaroaleman commented Jun 8, 2021
View reviewed changes
Comment thread prow/plank/controller_test.go
ExpectedState: prowapi.PendingState,
ExpectedComplete: false,
ExpectedNumPods: 1,
ExpectedNumPods: 0,
Copy link
Copy Markdown
Member Author

@alvaroaleman alvaroaleman Jun 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed because of kubernetes-sigs/controller-runtime#1399, the fakeclient now handles finalizers by itself so updating an object with deletion timestamp set to remove a finalizer will result in deletion

@alvaroaleman
Update Kube dependencies to v1.21 level
a05e752 
No specific reason other than hoping things will be somehow better :)
@BenTheElder
Copy link
Copy Markdown
Member

BenTheElder commented Jun 8, 2021

What is prow.k8s.io running these days?

@alvaroaleman
Copy link
Copy Markdown
Member Author

alvaroaleman commented Jun 8, 2021

This is just about the client libs, since we don't use any features that require a new apiserver version this should work just fine even with an old apiserver

cjwagner
cjwagner approved these changes Jun 8, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@cjwagner cjwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is prow.k8s.io running these days?

Currently 1.17.17-gke.4900

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jun 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, cjwagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit 953d79c into kubernetes:master Jun 8, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjwagner cjwagner cjwagner approved these changes

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@clarketm clarketm Awaiting requested review from clarketm

Assignees

@cjwagner cjwagner

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow/plank Issues or PRs related to prow's plank component area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

v1.22

Development

Successfully merging this pull request may close these issues.

4 participants

@alvaroaleman @BenTheElder @k8s-ci-robot @cjwagner