image-build/capg: add periodic job to build gce images#22041
image-build/capg: add periodic job to build gce images#22041k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Conversation
config/jobs/kubernetes-sigs/image-builder/image-builder-periodics.yaml
Outdated
Show resolved
Hide resolved
|
/retitle [WIP] image-build/capg: add periodic job to build gce images |
|
@cpanato needs a rebase |
|
@cpanato there are still 2 issues we will have to work through:
|
|
I honestly didn't know that image-pushing config was even there for GCP (not an area that I've ever been involved with). But what's happening here makes sense to me. |
|
Added the same owners as described https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/image-builder/OWNERS added the periodic job inside the wg-infra trusted, see the PR for the enable the API and associations for the trusted cluster: kubernetes/k8s.io#2025 |
|
@cpanato I don't particularly mind having this job here but I think https://github.com/kubernetes/test-infra/tree/master/config/jobs/kubernetes-sigs/image-builder is a better place for this job. |
But to run in the trusted cluster i need to add the job in this directory right? Only if dont need to run in the trused cluster then i can rearrange and update the service account attribution. Did that because Aaron post in the PR the trusted thing |
|
/hold cancel kubernetes/k8s.io#2025 is merged and we can merge kubernetes-sigs/image-builder#445 so I think we are good to move on for the validation part |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam, cpanato The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
You don't necessarily need to add a job in this specific directory to make it run in |
|
@cpanato: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ameukam ahh, will open a PR to move this out |
/hold for kubernetes-sigs/image-builder#445
/assign @CecileRobertMichon @dims @codenrhoden
TODO: