Skip to content

image-build/capg: add periodic job to build gce images#22041

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
cpanato:add-periodic
May 19, 2021
Merged

image-build/capg: add periodic job to build gce images#22041
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
cpanato:add-periodic

Conversation

@cpanato
Copy link
Copy Markdown
Member

@cpanato cpanato commented May 1, 2021

  • remove the temporary job created
  • add a periodic job to build the gce images

/hold for kubernetes-sigs/image-builder#445

/assign @CecileRobertMichon @dims @codenrhoden

TODO:

  • create a GCP project to have the images published
  • change this periodic to use the project and publish nightly builds

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 1, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/jobs labels May 1, 2021
@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 1, 2021
@k8s-ci-robot k8s-ci-robot requested review from dims and spiffxp May 1, 2021 15:46
@dims
Copy link
Copy Markdown
Member

dims commented May 1, 2021

/retitle [WIP] image-build/capg: add periodic job to build gce images

@k8s-ci-robot k8s-ci-robot changed the title image-build/capg: add periodic job to build gce images [WIP] image-build/capg: add periodic job to build gce images May 1, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 1, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 2, 2021
@dims
Copy link
Copy Markdown
Member

dims commented May 2, 2021

@cpanato needs a rebase

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 2, 2021
@dims
Copy link
Copy Markdown
Member

dims commented May 2, 2021

@cpanato there are still 2 issues we will have to work through:

  • Does the service account that gets injected have access to the CAPG staging cluster
  • Does the CAPG staging cluster have gcloud compute api service enabled.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 2, 2021
@codenrhoden
Copy link
Copy Markdown
Contributor

I honestly didn't know that image-pushing config was even there for GCP (not an area that I've ever been involved with). But what's happening here makes sense to me.

@cpanato
Copy link
Copy Markdown
Member Author

cpanato commented May 16, 2021

Added the same owners as described https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/image-builder/OWNERS
Don't know if need to add the CAPG maintainers as well

added the periodic job inside the wg-infra trusted, see the PR for the enable the API and associations for the trusted cluster: kubernetes/k8s.io#2025

cc @dims @ameukam @spiffxp

@ameukam
Copy link
Copy Markdown
Member

ameukam commented May 17, 2021

@cpanato I don't particularly mind having this job here but I think https://github.com/kubernetes/test-infra/tree/master/config/jobs/kubernetes-sigs/image-builder is a better place for this job.

@cpanato
Copy link
Copy Markdown
Member Author

cpanato commented May 17, 2021

@cpanato I don't particularly mind having this job here but I think https://github.com/kubernetes/test-infra/tree/master/config/jobs/kubernetes-sigs/image-builder is a better place for this job.

But to run in the trusted cluster i need to add the job in this directory right? Only if dont need to run in the trused cluster then i can rearrange and update the service account attribution.

Did that because Aaron post in the PR the trusted thing

@cpanato cpanato changed the title [WIP] image-build/capg: add periodic job to build gce images image-build/capg: add periodic job to build gce images May 19, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 19, 2021
@cpanato
Copy link
Copy Markdown
Member Author

cpanato commented May 19, 2021

/hold cancel

kubernetes/k8s.io#2025 is merged and we can merge kubernetes-sigs/image-builder#445

so I think we are good to move on for the validation part
@ameukam @spiffxp

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 19, 2021
@ameukam
Copy link
Copy Markdown
Member

ameukam commented May 19, 2021

/approve
/lgtm
(not sure if I have the permission)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, cpanato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2021
@ameukam
Copy link
Copy Markdown
Member

ameukam commented May 19, 2021

@cpanato I don't particularly mind having this job here but I think https://github.com/kubernetes/test-infra/tree/master/config/jobs/kubernetes-sigs/image-builder is a better place for this job.

But to run in the trusted cluster i need to add the job in this directory right? Only if dont need to run in the trused cluster then i can rearrange and update the service account attribution.

You don't necessarily need to add a job in this specific directory to make it run in k8s-infra-prow-build-trusted. For instance post-cluster-api-push-images is in a different directory:

kubernetes-sigs/cluster-api:
- name: post-cluster-api-push-images
cluster: k8s-infra-prow-build-trusted
annotations:

@k8s-ci-robot k8s-ci-robot merged commit 563598f into kubernetes:master May 19, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 19, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@cpanato: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key image-builder-periodics.yaml using file config/jobs/kubernetes/wg-k8s-infra/trusted/image-builder/image-builder-periodics.yaml
Details

In response to this:

  • remove the temporary job created
  • add a periodic job to build the gce images

/hold for kubernetes-sigs/image-builder#445

/assign @CecileRobertMichon @dims @codenrhoden

TODO:

  • create a GCP project to have the images published
  • change this periodic to use the project and publish nightly builds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cpanato cpanato deleted the add-periodic branch May 19, 2021 07:57
@cpanato
Copy link
Copy Markdown
Member Author

cpanato commented May 19, 2021

@ameukam ahh, will open a PR to move this out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants