cluster-api-provider-openstack: enable and enforce e2e tests on PR#21536
cluster-api-provider-openstack: enable and enforce e2e tests on PR#21536k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/assign @jichenjc Can you please take a look? Thx. I will until kubernetes-sigs/cluster-api-provider-openstack#798 is merged |
|
/lgtm reasonable to me , we can merge this after the e2e PR is merged |
Thx :) I'll unhold after it's merged. |
|
/hold cancel |
|
@sbueringer: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The idea is to run the e2e tests on every PR and make them mandatory for merge. I would keep conformance tests optional. They can be run if somebody wants to, but we don't start them automatically and they are not required for merging. (they are ran periodically, see: https://testgrid.k8s.io/sig-cluster-lifecycle-cluster-api-provider-openstack#periodic-conformance-test-master)