Skip to content

cluster-api-provider-openstack: enable and enforce e2e tests on PR#21536

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
c445:pr-enable-e2e-tests
Mar 30, 2021
Merged

cluster-api-provider-openstack: enable and enforce e2e tests on PR#21536
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
c445:pr-enable-e2e-tests

Conversation

@sbueringer
Copy link
Copy Markdown
Member

@sbueringer sbueringer commented Mar 26, 2021

The idea is to run the e2e tests on every PR and make them mandatory for merge. I would keep conformance tests optional. They can be run if somebody wants to, but we don't start them automatically and they are not required for merging. (they are ran periodically, see: https://testgrid.k8s.io/sig-cluster-lifecycle-cluster-api-provider-openstack#periodic-conformance-test-master)

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 26, 2021
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 26, 2021
@sbueringer
Copy link
Copy Markdown
Member Author

/assign @jichenjc

Can you please take a look? Thx.

I will
/hold

until kubernetes-sigs/cluster-api-provider-openstack#798 is merged

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2021
@jichenjc
Copy link
Copy Markdown
Contributor

/lgtm

reasonable to me , we can merge this after the e2e PR is merged

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2021
@sbueringer
Copy link
Copy Markdown
Member Author

/lgtm

reasonable to me , we can merge this after the e2e PR is merged

Thx :) I'll unhold after it's merged.

@sbueringer
Copy link
Copy Markdown
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 30, 2021
@k8s-ci-robot k8s-ci-robot merged commit a4e1a97 into kubernetes:master Mar 30, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 30, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@sbueringer: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-provider-openstack-presubmits.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-openstack/cluster-api-provider-openstack-presubmits.yaml
Details

In response to this:

The idea is to run the e2e tests on every PR and make them mandatory for merge. I would keep conformance tests optional. They can be run if somebody wants to, but we don't start them automatically and they are not required for merging. (they are ran periodically, see: https://testgrid.k8s.io/sig-cluster-lifecycle-cluster-api-provider-openstack#periodic-conformance-test-master)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer sbueringer deleted the pr-enable-e2e-tests branch March 30, 2021 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants