Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Kubeflow Katib from post-submit jobs #19818

Merged

Conversation

andreyvelich
Copy link
Contributor

We can remove Kubeflow Katib from post-submit jobs.
We will use AWS infra for our release/post-submits process, corresponding issues: kubeflow/katib#1332 and kubeflow/katib#1367.

Here is the PR to switch pre-submits to AWS infra: kubeflow/katib#1356.

/assign @jlewi @Jeffwan @PatrickXYS
/cc @gaocegege @johnugeorge

@k8s-ci-robot
Copy link
Contributor

@andreyvelich: GitHub didn't allow me to assign the following users: PatrickXYS.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

We can remove Kubeflow Katib from post-submit jobs.
We will use AWS infra for our release/post-submits process, corresponding issues: kubeflow/katib#1332 and kubeflow/katib#1367.

Here is the PR to switch pre-submits to AWS infra: kubeflow/katib#1356.

/assign @jlewi @Jeffwan @PatrickXYS
/cc @gaocegege @johnugeorge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 3, 2020
@k8s-ci-robot
Copy link
Contributor

@andreyvelich: GitHub didn't allow me to request PR reviews from the following users: gaocegege, johnugeorge.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

We can remove Kubeflow Katib from post-submit jobs.
We will use AWS infra for our release/post-submits process, corresponding issues: kubeflow/katib#1332 and kubeflow/katib#1367.

Here is the PR to switch pre-submits to AWS infra: kubeflow/katib#1356.

/assign @jlewi @Jeffwan @PatrickXYS
/cc @gaocegege @johnugeorge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

Welcome @andreyvelich!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @andreyvelich. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/testgrid sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 3, 2020
@PatrickXYS
Copy link
Contributor

@andreyvelich Looks like you need to sign the CLA

/lgtm

@k8s-ci-robot
Copy link
Contributor

@PatrickXYS: changing LGTM is restricted to collaborators

In response to this:

@andreyvelich Looks like you need to sign the CLA

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andreyvelich
Copy link
Contributor Author

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 3, 2020
@Jeffwan
Copy link
Contributor

Jeffwan commented Nov 3, 2020

/ok-to-test

Do you want to remove it now? I think CD process is not up yet?

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 3, 2020
@andreyvelich
Copy link
Contributor Author

/ok-to-test

Do you want to remove it now? I think CD process is not up yet?

@Jeffwan I think, we can remove it. We are not using post-submit in prow-config.
To release images, currently we manually run script, check this: kubeflow/katib#1371 (comment).

@Jeffwan
Copy link
Contributor

Jeffwan commented Nov 3, 2020

@andreyvelich Got it.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2020
@jlewi
Copy link
Contributor

jlewi commented Nov 3, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2020
@Jeffwan
Copy link
Contributor

Jeffwan commented Nov 3, 2020

/test pull-test-infra-bazel

@andreyvelich
Copy link
Contributor Author

/test pull-test-infra-bazel

@k8s-ci-robot k8s-ci-robot merged commit b661c12 into kubernetes:master Nov 4, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 4, 2020
@k8s-ci-robot
Copy link
Contributor

@andreyvelich: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kubeflow-postsubmits.yaml using file config/jobs/kubeflow/kubeflow-postsubmits.yaml

In response to this:

We can remove Kubeflow Katib from post-submit jobs.
We will use AWS infra for our release/post-submits process, corresponding issues: kubeflow/katib#1332 and kubeflow/katib#1367.

Here is the PR to switch pre-submits to AWS infra: kubeflow/katib#1356.

/assign @jlewi @Jeffwan @PatrickXYS
/cc @gaocegege @johnugeorge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andreyvelich andreyvelich deleted the remove-katib-postsubmit branch June 6, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants