releng(image-promoter): Add canary jobs for image promotion #19789

justaugustus · 2020-10-31T05:32:03Z

This is a step towards running the image promotion jobs on the
k8s-infra-prow-build-trusted instead of test-infra-trusted. (ref: kubernetes-sigs/promo-tools#269, kubernetes/k8s.io#157)

Differences from the prod jobs:

Runs in k8s-infra-prow-build-trusted
Uses -dry-run=true
Jobs renamed to include 'image-promo' for clarity
Job names are suffixed with '-canary'
Periodic runs every 2 hours (instead of every 4 hours)
Rerun enabled for Release Managers

Signed-off-by: Stephen Augustus [email protected]

/hold for @spiffxp or @dims review
cc: @listx @thockin @kubernetes/release-engineering

justaugustus · 2020-10-31T05:32:30Z

/assign @spiffxp @dims

hasheddan

/lgtm

justaugustus · 2020-10-31T05:58:56Z

/hold for adding service accts (

test-infra/config/prow/cluster/trusted_serviceaccounts.yaml

Lines 33 to 48 in bfe35ec

    
           --- 
        
           kind: ServiceAccount 
        
           apiVersion: v1 
        
           metadata: 
        
             annotations: 
        
               iam.gke.io/gcp-service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com 
        
             name: k8s-infra-gcr-promoter 
        
             namespace: test-pods 
        
           --- 
        
           kind: ServiceAccount 
        
           apiVersion: v1 
        
           metadata: 
        
             annotations: 
        
               iam.gke.io/gcp-service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod-bak.iam.gserviceaccount.com 
        
             name: k8s-infra-gcr-promoter-bak 
        
             namespace: test-pods

) to k8s-infra-prow-build-trusted.

justaugustus · 2020-11-01T07:30:26Z

Opened the PR for adding the GCR promotion service accounts to k8s-infra-prow-build-trusted, here: kubernetes/k8s.io#1382

saschagrunert

/lgtm

cpanato · 2020-11-02T08:32:21Z

config/jobs/kubernetes/wg-k8s-infra/trusted/releng/releng-trusted.yaml

+      - -thin-manifest-dir=/home/prow/go/src/github.com/kubernetes/k8s.io/k8s.gcr.io
+      - -dry-run=true
+  annotations:
+    testgrid-dashboards: sig-release-releng-blocking, wg-k8s-infra-k8sio


if is a canary, can we move to the informing dashboard? when this is stable and we promote to official we move to the blocking dashboard. wdyt?

I thought about that, but I consider this canaries to be "blocking" as well.

What I didn't want to happen is us to cut these over to the real jobs and have them missing from the blocking dashboard.

cpanato

/lgtm

justaugustus · 2020-11-02T14:15:21Z

(Updated alert addresses to match #19797.)
/test pull-test-infra-bazel

spiffxp · 2020-11-02T14:47:48Z

Periodic runs every 30 minutes (instead of every 4 hours)

Is this going to exhaust rate limits?

spiffxp · 2020-11-02T17:48:30Z

I was thinking of #16727 which I found via https://github.com/kubernetes/test-infra/blame/master/config/jobs/kubernetes/test-infra/test-infra-trusted.yaml

At the time, that blew through quota at a 1h interval

This is a step towards running the image promotion jobs on the k8s-infra-prow-build-trusted instead of test-infra-trusted. Differences from the prod jobs: - Runs in k8s-infra-prow-build-trusted - Uses -dry-run=true - Jobs renamed to include 'image-promo' for clarity - Job names are suffixed with '-canary' - Periodic runs every 2 hours (instead of every 4 hours) - Rerun enabled for Release Managers Signed-off-by: Stephen Augustus <[email protected]>

justaugustus · 2020-11-02T18:18:53Z

/hold cancel

kubernetes/k8s.io#1382 has merged and I've updated the periodic interval to 2 hours, based on the convo with @spiffxp here: https://kubernetes.slack.com/archives/CJH2GBF7Y/p1604339284066200?thread_ts=1604327026.060900&cid=CJH2GBF7Y

spiffxp

/approve
/lgtm

k8s-ci-robot · 2020-11-02T20:02:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, hasheddan, justaugustus, saschagrunert, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~config/jobs/kubernetes/wg-k8s-infra/trusted/releng/OWNERS~~ [cpanato,hasheddan,justaugustus,saschagrunert,spiffxp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2020-11-02T20:12:19Z

@justaugustus: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

key releng-trusted.yaml using file config/jobs/kubernetes/wg-k8s-infra/trusted/releng/releng-trusted.yaml

In response to this:

This is a step towards running the image promotion jobs on the
k8s-infra-prow-build-trusted instead of test-infra-trusted. (ref: kubernetes-sigs/promo-tools#269, kubernetes/k8s.io#157)

Differences from the prod jobs:

Runs in k8s-infra-prow-build-trusted

Uses -dry-run=true

Jobs renamed to include 'image-promo' for clarity

Job names are suffixed with '-canary'

Periodic runs every 2 hours (instead of every 4 hours)

Rerun enabled for Release Managers

Signed-off-by: Stephen Augustus [email protected]

/hold for @spiffxp or @dims review
cc: @listx @thockin @kubernetes/release-engineering

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 31, 2020

k8s-ci-robot requested review from cpanato and hasheddan October 31, 2020 05:32

k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 31, 2020

k8s-ci-robot assigned dims and spiffxp Oct 31, 2020

justaugustus mentioned this pull request Oct 31, 2020

container-image-promoter jobs that currently run in the google.com-owned prow.k8s.io service cluster should run in community-owned infrastructure kubernetes-sigs/promo-tools#269

Closed

8 tasks

hasheddan approved these changes Oct 31, 2020

View reviewed changes

k8s-ci-robot assigned hasheddan Oct 31, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2020

justaugustus mentioned this pull request Nov 1, 2020

infra(k8s-infra-prow-build-trusted): Add promoter service accounts kubernetes/k8s.io#1382

Merged

saschagrunert approved these changes Nov 2, 2020

View reviewed changes

k8s-ci-robot assigned saschagrunert Nov 2, 2020

cpanato reviewed Nov 2, 2020

View reviewed changes

cpanato approved these changes Nov 2, 2020

View reviewed changes

k8s-ci-robot assigned cpanato Nov 2, 2020

justaugustus force-pushed the cip-to-k8s-infra branch from b079f1b to 763e206 Compare November 2, 2020 14:13

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2020

justaugustus force-pushed the cip-to-k8s-infra branch from 763e206 to 997a139 Compare November 2, 2020 18:16

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 2, 2020

spiffxp approved these changes Nov 2, 2020

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2020

k8s-ci-robot merged commit a3761ed into kubernetes:master Nov 2, 2020

k8s-ci-robot added this to the v1.20 milestone Nov 2, 2020

This was referenced Nov 2, 2020

releng: Migrate image promotion jobs to k8s-infra-prow-build-trusted #19810

Merged

releng: Promote vulndash:v0.3.0 kubernetes/k8s.io#1385

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

releng(image-promoter): Add canary jobs for image promotion #19789

releng(image-promoter): Add canary jobs for image promotion #19789

justaugustus commented Oct 31, 2020 •

edited

Loading

justaugustus commented Oct 31, 2020

hasheddan left a comment

justaugustus commented Oct 31, 2020

justaugustus commented Nov 1, 2020

saschagrunert left a comment

cpanato Nov 2, 2020

justaugustus Nov 2, 2020 •

edited

Loading

cpanato left a comment

justaugustus commented Nov 2, 2020

spiffxp commented Nov 2, 2020

spiffxp commented Nov 2, 2020

justaugustus commented Nov 2, 2020

spiffxp left a comment

k8s-ci-robot commented Nov 2, 2020

k8s-ci-robot commented Nov 2, 2020

releng(image-promoter): Add canary jobs for image promotion #19789

releng(image-promoter): Add canary jobs for image promotion #19789

Conversation

justaugustus commented Oct 31, 2020 • edited Loading

justaugustus commented Oct 31, 2020

hasheddan left a comment

Choose a reason for hiding this comment

justaugustus commented Oct 31, 2020

justaugustus commented Nov 1, 2020

saschagrunert left a comment

Choose a reason for hiding this comment

cpanato Nov 2, 2020

Choose a reason for hiding this comment

justaugustus Nov 2, 2020 • edited Loading

Choose a reason for hiding this comment

cpanato left a comment

Choose a reason for hiding this comment

justaugustus commented Nov 2, 2020

spiffxp commented Nov 2, 2020

spiffxp commented Nov 2, 2020

justaugustus commented Nov 2, 2020

spiffxp left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Nov 2, 2020

k8s-ci-robot commented Nov 2, 2020

justaugustus commented Oct 31, 2020 •

edited

Loading

justaugustus Nov 2, 2020 •

edited

Loading