Allow staging via krel for kubetest by saschagrunert · Pull Request #19488 · kubernetes/test-infra

saschagrunert · 2020-10-08T10:31:52Z

We changed a bunch of dependencies in k/release so we can give this a try again

This adds a new --use-krel flag to kubetest to indicate that we want to stage the sources directly via the API provided by k/release rather than the deprecated push-build.sh script (lives in k/release, too).

The idea is to add another job later on for testing this flag on a non critical Kubernetes build+push job (should live in sig-release).

saschagrunert · 2020-10-08T10:32:27Z

cc @kubernetes/release-engineering

xmudrii

Left two nits, but otherwise looks okay to me.

kubetest/main.go

saschagrunert · 2020-10-08T12:05:49Z

Green tests 💚

xmudrii

/lgtm

saschagrunert · 2020-10-12T07:29:20Z

Rebased on top of the latest master branch.

go.mod

fejta · 2020-12-01T20:24:30Z

/retest

saschagrunert · 2020-12-02T08:24:35Z

/retest

Hm, it looks like the project does not build any more correctly with the dependency change… 🤔

spiffxp · 2021-01-19T20:49:10Z

needs rebase

This adds a new `--use-krel` flag to kubetest to indicate that we want to stage the sources directly via the API provided by k/release rather than the deprecated push-build.sh script (lives in k/release, too). The idea is to add another job later on for testing this flag on a non critical Kubernetes build+push job (should live in sig-release). Signed-off-by: Sascha Grunert <sgrunert@suse.com> Signed-off-by: Sascha Grunert <mail@saschagrunert.de>

saschagrunert · 2021-01-20T08:15:53Z

prow/test/integration/test/overall_test.go


-	http://www.apache.org/licenses/LICENSE-2.0
-
+    http://www.apache.org/licenses/LICENSE-2.0


Looks like this file is causing the boilerplate test to fail, but I did not change it in this PR. 🤷

saschagrunert · 2021-01-20T08:24:19Z

needs rebase

Done, please take another look :)

BenTheElder · 2021-01-20T09:34:13Z

didn't we land this in kubetest2?
I'm hesitant to keep fiddling with kubetest, the blast radius is huge and the code is a maze.

I'm also concerned about dependency cycles, like #20422

saschagrunert · 2021-01-20T09:41:45Z

didn't we land this in kubetest2?
I'm hesitant to keep fiddling with kubetest, the blast radius is huge and the code is a maze.

Yes, the main intention of this change is to be able to completely remove the push-build script in a feasible amount of time. Do you think we can switch to kubetest2 in the near future and convert the old jobs to it? If so, then I'm happy to drop this PR.

fejta · 2021-02-04T02:50:39Z

Can we close or update or lgtm or whatever this PR?

Looks like it also needs a rebase now

k8s-ci-robot · 2021-02-04T02:50:46Z

@saschagrunert: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

amwat · 2021-02-04T07:10:31Z

+1 hesistant to make changes to kubetest. We've landed this in kubetest2 successfully and I'm working on a migration plan for kubetest deprecation. I'm inclined to have it solved that way.

BenTheElder · 2021-02-04T07:54:00Z

Yes, the main intention of this change is to be able to completely remove the push-build script in a feasible amount of time.

to what end though? is this script actually being actively touched today? if so: why?

As a general rule we avoid substantially changing CI for existing kubernetes release branches, so we'd probably want to wait N releases to no longer have any jobs using this.

Do you think we can switch to kubetest2 in the near future and convert the old jobs to it? If so, then I'm happy to drop this PR.

I'm not sure we should be converting old release branches, regardless of if it's swapping out push-build.sh, or kubetest ...

BenTheElder

I'm not sure if it's just because the PR is out of date, but this seems prettty heavy on the dependencies for something that should just need to talk to GCS and read some files from disk ...

BenTheElder · 2021-02-04T07:53:23Z

repos.bzl

+        name = "com_github_bazelbuild_rules_go",
+        build_file_generation = "on",
+        build_file_proto_mode = "disable",
+        importpath = "github.com/bazelbuild/rules_go",


why are we now importing rules_go as a go library? 🤔

BenTheElder · 2021-02-04T07:54:17Z

repos.bzl

+        name = "com_github_cilium_ebpf",
+        build_file_generation = "on",
+        build_file_proto_mode = "disable",
+        importpath = "github.com/cilium/ebpf",


... and ebpf ???

saschagrunert · 2021-02-04T08:49:54Z

As it looks like that the majority does not want this PR to get merged :)
/close

k8s-ci-robot · 2021-02-04T08:50:05Z

@saschagrunert: Closed this PR.

Details

In response to this:

As it looks like that the majority does not want this PR to get merged :)
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 8, 2020

k8s-ci-robot requested review from fejta and shyamjvs October 8, 2020 10:32

k8s-ci-robot added area/kubetest sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 8, 2020

xmudrii reviewed Oct 8, 2020

View reviewed changes

kubetest/main.go Outdated Show resolved Hide resolved

kubetest/main.go Show resolved Hide resolved

saschagrunert force-pushed the stage-via-krel-2 branch from 5325020 to 3c0aa6f Compare October 8, 2020 10:45

saschagrunert mentioned this pull request Oct 8, 2020

Integrate krel push into anago and test-infra kubernetes/release#1578

Closed

4 tasks

saschagrunert force-pushed the stage-via-krel-2 branch 3 times, most recently from 3ce4a44 to 0c01494 Compare October 8, 2020 11:55

xmudrii approved these changes Oct 8, 2020

View reviewed changes

k8s-ci-robot assigned xmudrii Oct 8, 2020

k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 8, 2020

saschagrunert force-pushed the stage-via-krel-2 branch from 0c01494 to d8782db Compare October 12, 2020 07:28

k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 12, 2020

saschagrunert force-pushed the stage-via-krel-2 branch 2 times, most recently from a2315ff to 5068e8b Compare October 14, 2020 08:19

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 15, 2020

saschagrunert force-pushed the stage-via-krel-2 branch from 5068e8b to 1f3085f Compare October 15, 2020 09:02

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 15, 2020

fejta reviewed Oct 23, 2020

View reviewed changes

go.mod Outdated Show resolved Hide resolved

go.mod Show resolved Hide resolved

saschagrunert mentioned this pull request Oct 27, 2020

ci-kubernetes-build jobs may upload incomplete set of artfacts #18808

Closed

saschagrunert mentioned this pull request Nov 3, 2020

Update yaml.v3 to the latest commit #19816

Closed

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 19, 2021

saschagrunert force-pushed the stage-via-krel-2 branch from fc63c52 to 725a1e1 Compare January 20, 2021 07:46

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 20, 2021

saschagrunert force-pushed the stage-via-krel-2 branch from 725a1e1 to bd6e43f Compare January 20, 2021 07:50

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. area/prow Issues or PRs related to prow and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 20, 2021

saschagrunert force-pushed the stage-via-krel-2 branch from bd6e43f to 052daf3 Compare January 20, 2021 08:06

saschagrunert force-pushed the stage-via-krel-2 branch from 052daf3 to 2894d43 Compare January 20, 2021 08:15

saschagrunert commented Jan 20, 2021

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 4, 2021

BenTheElder assigned amwat Feb 4, 2021

BenTheElder reviewed Feb 4, 2021

View reviewed changes

k8s-ci-robot closed this Feb 4, 2021

saschagrunert deleted the stage-via-krel-2 branch February 4, 2021 08:50


		http://www.apache.org/licenses/LICENSE-2.0

		http://www.apache.org/licenses/LICENSE-2.0

Conversation

saschagrunert commented Oct 8, 2020

Uh oh!

saschagrunert commented Oct 8, 2020

Uh oh!

xmudrii left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

saschagrunert commented Oct 8, 2020

Uh oh!

xmudrii left a comment

Choose a reason for hiding this comment

Uh oh!

saschagrunert commented Oct 12, 2020

Uh oh!

Uh oh!

Uh oh!

fejta commented Dec 1, 2020

Uh oh!

saschagrunert commented Dec 2, 2020

Uh oh!

spiffxp commented Jan 19, 2021

Uh oh!

saschagrunert Jan 20, 2021

Choose a reason for hiding this comment

Uh oh!

saschagrunert commented Jan 20, 2021

Uh oh!

BenTheElder commented Jan 20, 2021

Uh oh!

saschagrunert commented Jan 20, 2021

Uh oh!

fejta commented Feb 4, 2021

Uh oh!

k8s-ci-robot commented Feb 4, 2021

Uh oh!

amwat commented Feb 4, 2021

Uh oh!

BenTheElder commented Feb 4, 2021

Uh oh!

BenTheElder left a comment

Choose a reason for hiding this comment

Uh oh!

BenTheElder Feb 4, 2021

Choose a reason for hiding this comment

Uh oh!

BenTheElder Feb 4, 2021

Choose a reason for hiding this comment

Uh oh!

saschagrunert commented Feb 4, 2021

Uh oh!

k8s-ci-robot commented Feb 4, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants