re-enable all node flaky test, move node performance test to new job #19352
Conversation
Filtering of test runs in perf-image-config.yaml means only specific tests matching "Node Performance Testing" run in flaky job. - Move flaky test job back to general image-config.yaml. - Create new job config specific to "Node Performance Testing". - Decrease ci interval of new "Node Performance Testing" job to 12h instead of 2h. A separate PR in kubernetes/kubernetes needs to be made to take "Node Performance Testing" tests out of the flaky job.
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
area/jobs
sig/node
|
Previous work, #17687, including my own comment, #17687 (comment) |
|
/assign @sjenning |
|
kubernetes/kubernetes#95040 should go in first, probably. |
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
k8s-ci-robot
added
the
lifecycle/stale
|
/test pull-test-infra-integration |
|
@SergeyKanzhelev This is still relevant, because without it, we're not running anything marked as 'Flaky' anywhere ever. It does mean they don't ever fail, but at that point, we can just delete all the tests. Additionally, we should de-footgun this by making it an error to specify tests in the image if they are specified as TODO to make a list of all tests marked as FLAKY. |
|
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
k8s-ci-robot
added
lifecycle/rotten
|
Rotten issues close after 30d of inactivity. Send feedback to sig-contributor-experience at kubernetes/community. |
|
@fejta-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/remove-lifecycle rotten |
|
@spiffxp: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
removed
the
lifecycle/rotten
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: MHBauer The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign |
| @@ -189,7 +189,7 @@ periodics: | |||
| - --deployment=node | |||
| - --gcp-project-type=node-e2e-project | |||
| - --gcp-zone=us-west1-b | |||
| - --node-args=--image-config-file=/workspace/test-infra/jobs/e2e_node/perf-image-config.yaml | |||
| - --node-args=--image-config-file=/workspace/test-infra/jobs/e2e_node/image-config.yaml | |||
There was a problem hiding this comment.
should this tab repel the "Node Performance Testing" tests using the skip? I am very confused why this task picks up performance tests.
This definition says: - --test_args=--nodes=1 --focus="\[Flaky\]"
And name of the test doesn't include "Flaky":
E2eNode Suite.[sig-node] Node Performance Testing [Serial] [Slow] Run node performance testing with pre-defined workloads NAS parallel benchmark (NPB) suite - Embarrassingly Parallel (EP) workload [cos-stable1]E2eNode Suite.[sig-node] Node Performance Testing [Serial] [Slow] Run node performance testing with pre-defined workloads NAS parallel benchmark (NPB) suite - Embarrassingly Parallel (EP) workload [ubuntu]E2eNode Suite.[sig-node] Node Performance Testing [Serial] [Slow] Run node performance testing with pre-defined workloads NAS parallel benchmark (NPB) suite - Integer Sort (IS) workload [cos-stable1]E2eNode Suite.[sig-node] Node Performance Testing [Serial] [Slow] Run node performance testing with pre-defined workloads NAS parallel benchmark (NPB) suite - Integer Sort (IS) workload [ubuntu]
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
k8s-ci-robot
added
the
lifecycle/stale
k8s-ci-robot
added
the
needs-rebase
|
@MHBauer: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cc @manugupt1 |
|
@SergeyKanzhelev: GitHub didn't allow me to request PR reviews from the following users: manugupt1. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
cc @manugupt1 |
|
/close @manugupt1 to submit a follow-up |
|
@ehashman: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
From: kubernetes#19352 Filtering of test runs in perf-image-config.yaml means only specific tests matching "Node Performance Testing" run in flaky job. Move flaky test job back to general image-config.yaml. Create new job config specific to "Node Performance Testing". Decrease ci interval of new "Node Performance Testing" job to 12h instead of 2h.
From: kubernetes#19352 Filtering of test runs in perf-image-config.yaml means only specific tests matching "Node Performance Testing" run in flaky job. Move flaky test job back to general image-config.yaml. Create new job config specific to "Node Performance Testing". Decrease ci interval of new "Node Performance Testing" job to 12h instead of 2h.
From: kubernetes#19352 Filtering of test runs in perf-image-config.yaml means only specific tests matching "Node Performance Testing" run in flaky job. Move flaky test job back to general image-config.yaml. Create new job config specific to "Node Performance Testing". Decrease ci interval of new "Node Performance Testing" job to 12h instead of 2h.
From: kubernetes#19352 Filtering of test runs in perf-image-config.yaml means only specific tests matching "Node Performance Testing" run in flaky job. Move flaky test job back to general image-config.yaml. Create new job config specific to "Node Performance Testing". Decrease ci interval of new "Node Performance Testing" job to 12h instead of 2h.
Filtering of test runs in perf-image-config.yaml means only specific
tests matching "Node Performance Testing" run in flaky job.
instead of 2h.
A separate PR in kubernetes/kubernetes needs to be made to take "Node
Performance Testing" tests out of the flaky job. PR #95040