-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump COS image to latest version #17770
Conversation
Hi @bsdnet. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Roy Yang <[email protected]>
/assign @vpickard @bart0sh @MHBauer We can convert current images from cos-stables to cos-lts, image to image_family |
/ok-to-test |
@bsdnet Would it be better to start using |
tests should not fail at all whether GCP publish new image or not. GCP never deleted images.Once the image was published, it will only be marked as DEPRECATED, and always be there. The reason cos-stable-73-11647-510-0 failed is that the changeset 31b01ca is wrong. It uses cos-stable-73 instead of co-73. 11647-510-0 is never released via the cos-stable channel, and so it does not exist at all. It is released in cos-73-lts family. In short, it is very safe to use latest LTS image. As to whether to use 'image_family: cos-77-lts', let's do step by step. It also need more thinking. |
/assign @derekwaynecar @dchen1107 @spiffxp |
@bsdnet: GitHub didn't allow me to assign the following users: derekwaynecar. Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be the fastest way out of the hole of relying on missing images, and then we turn on the failure of non-matching regexes, and then we schedule the image updates with the bumper if necessary.
If we affirmatively pick an image it's more explicit, and does not silently fail.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bsdnet, dims, MHBauer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Roy Yang [email protected]
kubernetes/kubernetes#91543 detect that stable image is gone. Now it silently failed. Instead, use the LTS image which will always succeed.