Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update containerd related tests using latest kubekins image #17695

Merged
merged 1 commit into from
May 27, 2020

Conversation

bsdnet
Copy link
Contributor

@bsdnet bsdnet commented May 23, 2020

Signed-off-by: Roy Yang [email protected]

What happened:

The following tests failed continuously in the past:
https://testgrid.k8s.io/sig-node-containerd#containerd-e2e-gci-1.2
https://testgrid.k8s.io/sig-node-containerd#containerd-node-e2e-1.2
https://testgrid.k8s.io/sig-node-containerd#containerd-node-e2e-features-1.2

What you expected to happen:
They should succeed.

How to reproduce it (as minimally and precisely as possible):
See https://testgrid.k8s.io/sig-node-containerd

Please provide links to example occurrences, if any:
See https://testgrid.k8s.io/sig-node-containerd

Anything else we need to know?:
From the log of https://testgrid.k8s.io/sig-node-containerd#containerd-e2e-gci-1.2, it mentioned that failing to get k8s image 1.3, which is removed from https://github.com/kubernetes/test-infra/blob/master/images/kubekins-e2e/variants.yaml. Also, kubekins container is out of date.

Ideally, we should use the latest stable kubekins image. Also, the reason bumping to 1.15 is that it is using the same golang version with latest containered.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 23, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @bsdnet. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 23, 2020
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 23, 2020
@bsdnet
Copy link
Contributor Author

bsdnet commented May 24, 2020

/assign @yujuhong

@dims
Copy link
Member

dims commented May 24, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 24, 2020
@dims
Copy link
Member

dims commented May 24, 2020

/approve
/lgtm
/assign @BenTheElder @spiffxp

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2020
@bsdnet
Copy link
Contributor Author

bsdnet commented May 24, 2020

/test pull-test-infra-bazel

@MHBauer
Copy link
Contributor

MHBauer commented May 26, 2020

should these be updated as part of #17715 ? how does one get into that automated flow?

@bsdnet
Copy link
Contributor Author

bsdnet commented May 26, 2020

should these be updated as part of #17715 ? how does one get into that automated flow?

That is a good question. I am not sure how other images are updated automatically. From the code reading, this image is special, and it use given verison golang and kubernetes. Recently, 1.3 was removed
from https://github.com/kubernetes/test-infra/blame/master/images/kubekins-e2e/variants.yaml

@spiffxp
Copy link
Member

spiffxp commented May 27, 2020

how does one get into that automated flow?

Use an image that gets built and pushed automatically. In this case, use a version of kubekins that lines up with a version of kubernetes that is still built and supported.

According the current documented policy, 1.15 is no longer in support. You'll want to move to 1.16 to keep up. In practice, the aged-out release jobs are kept around for a few weeks to cut a final patch release. Previous release schedules have included a date for when the old jobs would be removed, but I don't see one on the current release schedule (@kubernetes/patch-release-team @onlydole ?)

Longer term, jobs that need a per-release-branch variant should use config-forker annotations to have a job generated when the release-branch is cut

The code that does the bumping is here, fwiw: https://github.com/kubernetes/test-infra/tree/master/experiment/autobumper

@spiffxp
Copy link
Member

spiffxp commented May 27, 2020

/approve
All the above said, I'll merge this to unblock, as it's not making things any worse. Please address in followup PR's.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsdnet, dims, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2020
@k8s-ci-robot k8s-ci-robot merged commit a7af220 into kubernetes:master May 27, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 27, 2020
@k8s-ci-robot
Copy link
Contributor

@bsdnet: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key containerd.yaml using file config/jobs/kubernetes/sig-node/containerd.yaml

In response to this:

Signed-off-by: Roy Yang [email protected]

What happened:

The following tests failed continuously in the past:
https://testgrid.k8s.io/sig-node-containerd#containerd-e2e-gci-1.2
https://testgrid.k8s.io/sig-node-containerd#containerd-node-e2e-1.2
https://testgrid.k8s.io/sig-node-containerd#containerd-node-e2e-features-1.2

What you expected to happen:
They should succeed.

How to reproduce it (as minimally and precisely as possible):
See https://testgrid.k8s.io/sig-node-containerd

Please provide links to example occurrences, if any:
See https://testgrid.k8s.io/sig-node-containerd

Anything else we need to know?:
From the log of https://testgrid.k8s.io/sig-node-containerd#containerd-e2e-gci-1.2, it mentioned that failing to get k8s image 1.3, which is removed from https://github.com/kubernetes/test-infra/blob/master/images/kubekins-e2e/variants.yaml. Also, kubekins container is out of date.

Ideally, we should use the latest stable kubekins image. Also, the reason bumping to 1.15 is that it is using the same golang version with latest containered.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@onlydole
Copy link
Member

Thank you for the heads up, @spiffxp! It looks like the 1.15 removal dates fell off our schedule with our revisions and we’ll get them re-added 👍🏼

@bsdnet
Copy link
Contributor Author

bsdnet commented May 27, 2020

Thanks @spiffxp for your detailed explanation.

containered 1.2.x(https://github.com/containerd/containerd/releases/tag/v1.2.13) is officially built with golang 1.12.17 . That is why I bump to 1.15, which is the only version using the same golang per
https://github.com/kubernetes/test-infra/blob/master/images/kubekins-e2e/variants.yaml

I will follow up to move to 1.16, and it will be also nice for auto bumper to do that(remove from variant, bump the version.) I will take a look at that too.

@onlydole
Copy link
Member

@spiffxp - to follow up on the 1.15 job removal, I synced up with @justaugustus and SIG Release purposely removed the "1.15 job removal" entry from the schedule. The 1.15 jobs don't exactly correlate to any 1.19 workstreams, and previously, the beta.0 branch was a good time to perform that removal.

Now that the branch cut is on RC.0 AND we have an extended cycle, it's a little too late to have that branch around.

TL;DR - @justaugustus will be removing the 1.15 branch jobs as there are some expectations that the config-forker tooling has, so he will need to verify it still works when someone removes branch jobs "earlier" than the tool expects.

Please let me know if that makes sense, or if there are any other questions on that front, and we can address them!

@bsdnet bsdnet deleted the containerd branch May 28, 2020 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants