Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dockerless verify script to pull-kubernetes-typecheck #17566

Conversation

dims
Copy link
Member

@dims dims commented May 10, 2020

New tag added in kubernetes/kubernetes#87746

Signed-off-by: Davanum Srinivas [email protected]

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 10, 2020
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 10, 2020
@dims
Copy link
Member Author

dims commented May 10, 2020

/assign @wojtek-t @BenTheElder

@wojtek-t
Copy link
Member

@dims - I don't have enough context about it. What that is?

@dims
Copy link
Member Author

dims commented May 11, 2020

@wojtek-t we have a KEP that builds kubelet without needing docker/docker dependency ( please see kubernetes/enhancements#1546 ) This was implemented in kubernetes/kubernetes#87746. As part of that we added a new verify script https://github.com/kubernetes/kubernetes/blob/master/hack/verify-typecheck-dockerless.sh which we need to run in CI

@BenTheElder
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2020
@k8s-ci-robot k8s-ci-robot merged commit 7ab5bde into kubernetes:master May 12, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 12, 2020
@k8s-ci-robot
Copy link
Contributor

@dims: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key typecheck.yaml using file config/jobs/kubernetes/sig-testing/typecheck.yaml

In response to this:

New tag added in kubernetes/kubernetes#87746

Signed-off-by: Davanum Srinivas [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants