boskos core: don't attempt to create CRDs#16266
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom Feb 13, 2020
Merged
boskos core: don't attempt to create CRDs#16266k8s-ci-robot merged 1 commit intokubernetes:masterfrom
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
approved
This was referenced Feb 13, 2020
ixdy
force-pushed
the
boskos-separate-crd-creation
branch
from
481f6a9 to
3b48f53
Compare
k8s-ci-robot
removed
the
approved
Member
|
It has conflicts with your other PR 😬 |
k8s-ci-robot
added
the
needs-rebase
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
lgtm
ixdy
force-pushed
the
boskos-separate-crd-creation
branch
from
3b48f53 to
9b53b02
Compare
k8s-ci-robot
removed
lgtm
fejta
approved these changes
Feb 13, 2020
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fejta, ixdy The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recently had a brief outage because we changed some of the names in the Boskos CRDs, and updating these right now is tricky since Boskos attempts to create CRDs itself.
A simpler solution would be to just put the CRDs in YAMLs that can be applied with the rest of the Kubernetes resources, and not have Boskos attempt to create them itself. I'm working on that in a separate PR, to try to isolate concerns. (The existing code already does nothing if the CRDs already exist.)
Credit: @alvaroaleman already suggested doing this in #16206 (comment).
/assign @alvaroaleman @stevekuznetsov