Skip to content

controller-runtime: use go1.13 for release-0.4#15988

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
joelanford:controller-runtime-go-1.13
Feb 20, 2020
Merged

controller-runtime: use go1.13 for release-0.4#15988
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
joelanford:controller-runtime-go-1.13

Conversation

@joelanford
Copy link
Member

@joelanford joelanford commented Jan 22, 2020

Following up on #14373, this PR ensures that controller-runtime release-0.4 builds use go1.13

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 22, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @joelanford. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 22, 2020
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 22, 2020
@joelanford joelanford changed the title controller-runtime: use go1.12 for release-0.4 controller-runtime: use go1.13 for release-0.4 Jan 22, 2020
@joelanford joelanford force-pushed the controller-runtime-go-1.13 branch from 72a41a7 to 328cd4c Compare January 22, 2020 23:09
@chases2
Copy link
Contributor

chases2 commented Feb 11, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 11, 2020
@chases2
Copy link
Contributor

chases2 commented Feb 11, 2020

/assign @DirectXMan12
/assign @pwittrock

Copy link
Contributor

@DirectXMan12 DirectXMan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2020
@k8s-ci-robot k8s-ci-robot merged commit 6028066 into kubernetes:master Feb 20, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 20, 2020
@k8s-ci-robot
Copy link
Contributor

@joelanford: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key controller-runtime-presubmits-release-0.4.yaml using file config/jobs/kubernetes-sigs/controller-runtime/controller-runtime-presubmits-release-0.4.yaml
Details

In response to this:

Following up on #14373, this PR ensures that controller-runtime release-0.4 builds use go1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@joelanford joelanford deleted the controller-runtime-go-1.13 branch July 20, 2021 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants