Skip to content

Change cluster-api scratch bucket to -gcb suffix#14283

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
thockin:master
Sep 11, 2019
Merged

Change cluster-api scratch bucket to -gcb suffix#14283
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
thockin:master

Conversation

@thockin
Copy link
Member

@thockin thockin commented Sep 11, 2019

@Katharine @vincepri @detiber

The new bucket has been created. Once someone who knows Prow tells me it is safe, I will delete the old bucket.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 11, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 11, 2019
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

DetailsGit tree hash: 6b772eeec1cfa1ba16049ca34d03fa29a93c8284

@vincepri
Copy link
Member

/assign @Katharine

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Katharine, thockin, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2019
@thockin
Copy link
Member Author

thockin commented Sep 11, 2019

Do we need to coordinate any sort of push, or am I clear to clean up once this merges?

@detiber
Copy link
Contributor

detiber commented Sep 11, 2019

It should be good to clean after this merges and the prow config is updated.

@thockin
Copy link
Member Author

thockin commented Sep 11, 2019

I don't know what "and the prow config is updated" means practically - is there another PR? A human push action? A timeout?

@k8s-ci-robot k8s-ci-robot merged commit 495e99d into kubernetes:master Sep 11, 2019
@k8s-ci-robot
Copy link
Contributor

@thockin: Updated the job-config configmap in namespace default using the following files:

  • key k8s-staging-cluster-api.yaml using file config/jobs/image-pushing/k8s-staging-cluster-api.yaml
Details

In response to this:

@Katharine @vincepri @detiber

The new bucket has been created. Once someone who knows Prow tells me it is safe, I will delete the old bucket.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Sep 11, 2019
@Katharine
Copy link
Member

@thockin It's safe to remove now.

(It's that bot comment above, plus no old instances of the job still running.)

@thockin
Copy link
Member Author

thockin commented Sep 11, 2019

ACK, done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants