Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prow config is mixing camelCase, _underscores _, and -hyphens- #7971

Closed
0xmichalis opened this issue May 9, 2018 · 19 comments
Closed

Prow config is mixing camelCase, _underscores _, and -hyphens- #7971

0xmichalis opened this issue May 9, 2018 · 19 comments
Labels
area/prow Issues or PRs related to prow kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯

Comments

@0xmichalis
Copy link
Contributor

  • camelCase, eg. missingLabels in the tide config
  • underscores, mostly used eg. push_gateway
  • hyphens, eg. branch-protection

We should probably converge to a single format and stick with it.

@fejta @stevekuznetsov @cjwagner @BenTheElder @krzyzacy

/area prow

@k8s-ci-robot k8s-ci-robot added the area/prow Issues or PRs related to prow label May 9, 2018
@0xmichalis
Copy link
Contributor Author

/shrug

@k8s-ci-robot k8s-ci-robot added the ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯ label May 9, 2018
@stevekuznetsov
Copy link
Contributor

+1 to snake_case IMO

@BenTheElder
Copy link
Member

/kind bug
/area bikeshed

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label May 9, 2018
@BenTheElder
Copy link
Member

we should also document whatever we move to somewhere or have a config linter to prevent regressions.

@cjwagner
Copy link
Member

cjwagner commented May 9, 2018

I vote hyphens, but I don't care much as long as we are consistent.

@fejta
Copy link
Contributor

fejta commented May 9, 2018

pronounSubject_I verbPredicate_Think pronounSubject_We verbAuxilliary_Should verbPredicate_Use adjective_Hungarian nounDirect_Notation

@fejta
Copy link
Contributor

fejta commented May 9, 2018

We should make label_sync randomly assign a new color to the area/bikeshed label whenever the tool runs

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 7, 2018
@stevekuznetsov
Copy link
Contributor

/remove-lifecycle stale

If we want to look like k8s we should go with camelCase. Generically, can we write a serializer that loads either from field_name if present or fieldName if not? then we can do this migration slowly.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 31, 2018
@BenTheElder
Copy link
Member

We can add a new type embedding the real type temporarily that exposes the alternate field and then fixup that type into the real type.

+1 for going k8s style with camelCase for consistency.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 29, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 29, 2018
@idealhack
Copy link
Member

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Dec 31, 2018
@spiffxp
Copy link
Member

spiffxp commented Jan 3, 2019

/lifecycle frozen
/remove-kind bug
/kind cleanup
/milestone 2019-goals

Consistency helps discoverability and adoption

@k8s-ci-robot k8s-ci-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Jan 3, 2019
@k8s-ci-robot k8s-ci-robot added this to the 2019-goals milestone Jan 3, 2019
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/bug Categorizes issue or PR as related to a bug. labels Jan 3, 2019
@spiffxp spiffxp modified the milestones: 2019-goals, v1.17 Jul 25, 2019
@spiffxp spiffxp removed this from the v1.17 milestone Apr 16, 2020
@spiffxp
Copy link
Member

spiffxp commented Sep 11, 2020

/remove-lifecycle frozen
all the inconsistencies remain

@k8s-ci-robot k8s-ci-robot removed the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Sep 11, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 10, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 9, 2021
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/prow Issues or PRs related to prow kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯
Projects
None yet
Development

No branches or pull requests

9 participants