Remove cgroup v1/v2 only Kernel Config checks

[pacoxu]

https://man7.org/linux/man-pages/man7/cgroups.7.html (search in Linux 5.2 and earlier).)

#51 (comment)

To make it cherry-pickable, I opened this PR.

[neolit123]

adding these under optional it's still incorrect. it will warn for about options required (optional=warn) for both v1 and v2.

we definitely need the other PR.

• cgroup v1 and v2 kernel config check according to isCgroupV2 #52

but if we are backporting something i think it's better to remove them from config options and rely on the controller checks only. because controller enabled == kernel config enabled, right?
#51 (comment)

if we don't want to backport anything we could say it's a known bug and that they must skip preflight.

[pacoxu]

Removed.

Backport may be helpful to avoid some errors. But #41 was merged for system validator v1.9.0 which is kubernetes v1.32. (released in Dec 2024.)

[neolit123]

iiuc, we need to backport this commit to multiple sv and k8s versions.

i can cut the new sv releases, but would leave the backports to you.

[neolit123]

if you are going with removing the options, best to rename the commit and pr name.

[pacoxu]

/hold

Let me confirm this again.

[pacoxu]

if you are going with removing the options, best to rename the commit and pr name.

This was addressed.

If we backport this, it means users can pass the check without CGROUP_BPF for cgroup v2; and can pass without those CPUACCT/DEVICE/FREEZER for cgroup v1. Is that a bigger issue?

[pacoxu]

if you are going with removing the options, best to rename the commit and pr name.

This was addressed.

If we backport this, it means users can pass the check without CGROUP_BPF for cgroup v2; and can pass without those CPUACCT/DEVICE/FREEZER for cgroup v1. Is that a bigger issue?

Sorry. My fault. I forgot the cgroup controller checks.

It would be OK.

/unhold

[pacoxu]

I created a CR #54 here. [EDITED, wrong PR number]

[neolit123]

I created a CR #53 here.

i'm getting a bit confused.

i think we need to do this:

• have a single PR / commit that removes all v1 and v2 options, leaves only {Name: "CGROUPS"},
• we merge it in main here and backport it to SV versions, then backport it to k/k
• it makes sure users of v1 or v2 don't get any errors if they are missing options
• the other bigger PR can split the config options, we release a new MINOR here and add it to the latest k/k release

does that plan make sense?

[pacoxu]

I created a CR #53 here.

i'm getting a bit confused.

i think we need to do this:

• have a single PR / commit that removes all v1 and v2 options, leaves only {Name: "CGROUPS"},
• we merge it in main here and backport it to SV versions, then backport it to k/k
• it makes sure users of v1 or v2 don't get any errors if they are missing options
• the other bigger PR can split the config options, we release a new MINOR here and add it to the latest k/k release

does that plan make sense?

Totally agree.

[pacoxu]

Updated this PR and the CR #54

[neolit123]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [neolit123,pacoxu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[neolit123]

Updated this PR and the CR #54

i will cut 1.9.2 soon

[neolit123]

1.9.2
https://github.com/kubernetes/system-validators/releases/tag/v1.9.2

do we not need this in 1.10 as well?

[pacoxu]

1.9.2 https://github.com/kubernetes/system-validators/releases/tag/v1.9.2

do we not need this in 1.10 as well?

Yes @neolit123 v1.34 is using v1.10.1

[neolit123]

1.9.2 https://github.com/kubernetes/system-validators/releases/tag/v1.9.2
do we not need this in 1.10 as well?

Yes @neolit123 v1.34 is using v1.10.1

ok please send CR for release-1.10 and will create a new release there too.