Rename Features to Enhancements

[justaugustus]

/sig release
/assign @kacole2 @AishSundar @tpepper

Signed-off-by: Stephen Augustus [email protected]

[kacole2]

/approve

[AishSundar]

/approve /lgtm

There are a few places in the various release handbooks where the naming convention has to be modified eg: https://github.com/kubernetes/sig-release/tree/master/release-team/role-handbooks/release-team-lead. @justaugustus are you going to open GH issues for various leads to followup on?

/hold

[tao12345666333]

lgtm

[justaugustus]

@AishSundar -- I can search and replace the relevant role handbooks once this merges.

[AishSundar]

/hold cancel

[idvoretskyi]

@justaugustus can you point me to the source where this was publicly discussed?

[idvoretskyi]

/hold

[justaugustus]

@idvoretskyi -- it was mentioned during the Release Team meeting on 9/10, during our 1.13 nominations, to no objections.

Fair point though, should we announce this wider? The idea here was to essentially rebrand the role to fall more in line with the fact that we need to be tracking enhancements (KEPs, features, anything that falls under that umbrella) as opposed to just Features, as the KEPs process evolves.

Let me know what you think.

[nikhita]

Fair point though, should we announce this wider? The idea here was to essentially rebrand the role to fall more in line with the fact that we need to be tracking enhancements (KEPs, features, anything that falls under that umbrella) as opposed to just Features, as the KEPs process evolves.

Slightly related: should the label kind/feature be relabelled as kind/enhancement (or be introduced as a new label)?

/cc @spiffxp

[justaugustus]

@nikhita -- I'm not sure exactly where it was mentioned, but I remember there was discussion around deprecating kind/enhancement. It was subsequently replaced with kind/feature.

Enhancements ~= KEPs + Features

From kubernetes/community#2655 (comment):

We're introducing the idea of an umbrella term: Enhancements.
Enhancements are anything that modifies or adds new functionality to Kubernetes.

So KEPs and Features would both fall under that category.

KEP: multi-release event
Feature: hopefully only a single-release event

Features should roll into a KEP.

I think a good current example might be CoreDNS.

• Implementing CoreDNS == KEP
• CoreDNS as default in kubeadm == Feature

That said, we're working on introducing kind/kep, which would cover tracking KEPs. No need for an additional kind/enhancement label.

[idvoretskyi]

@justaugustus

Fair point though, should we announce this wider?

It would be great. My concern was not about the renaming itself (I'm definitely fine with that!), but about the agreement that hasn't been shared publicly.

[tpepper]

Lgtm in as much as it's correctly mechanically renaming.

But I do worry about the communication aspect and would like to see more out of SIG-PM on this and more community input. kubernetes/community#2655 is a step in that direction too. A developer looking at the release team, the contrib guide, and the devel guide, should have an easier path to understanding the enhancement process.

We shouldn't duplicate the eventual better documented process here in the sig release docs, but I think a small paragraph summary with links, definitions, and process highlights would make sense in the renamed enhancements role handbook. It should be more clear to the reader what's happening so for example @nikhita question would've already been answered in the doc with a few more words around "Enhancements ~= KEPs + [implementable?] Features".

Which then reminds me too:
https://github.com/kubernetes/community/blob/master/contributors/devel/release.md
should get some scrubbing relative to the change you're proposing here.

[idvoretskyi]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AishSundar, idvoretskyi, justaugustus, kacole2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [AishSundar,idvoretskyi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[idvoretskyi]

@justaugustus feel free to cancel hold once you'll be ready, looks good to me after the explanation.

[justaugustus]

/hold cancel

[AishSundar]

Cool, now that this is in I will make the announcement as part of 1.13 intro mail as well !

[justaugustus]

@AishSundar go for it! 🎉