Fix for yaml parsing issue #1974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
area/release-team
Comment on lines
-3
to
-5
| text: `MaxUnavailable` for `StatefulSets`, allows faster `RollingUpdate` by taking down | ||
| more than 1 pod at a time. The number of pods you want to take down during a `RollingUpdate` | ||
| is configurable using `maxUnavailable` parameter. |
There was a problem hiding this comment.
I think this has been generated from the krel input, right @csantanapr? If so, then we may have a bug here.
There was a problem hiding this comment.
@saschagrunert, this text was modified during PR review process by a person (ie me)
There was a problem hiding this comment.
I don't see what the error decoding note map: yaml: line 3: found character that cannot start any token is referring to
|
/lgtm |
saschagrunert
approved these changes
Jul 25, 2022
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csantanapr, Divya063, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
AnaMMedina21
added a commit
to AnaMMedina21/sig-release
that referenced
this pull request
Nov 11, 2022
<!-- Thanks for sending a pull request! Here are some tips for you: - If this is your first time, please read our contributor guidelines: https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide - Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request. For reference on required PR/issue labels, read here: https://git.k8s.io/community/contributors/devel/sig-release/release.md#issuepr-kind-label - If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews - If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests --> #### What type of PR is this: cleanup, Part 2 of PR kubernetes#2073 (issue #2753) <!-- Add one of the following kinds: /kind cleanup /kind documentation /kind feature /kind design --> #### What this PR does / why we need it: temp fix/workaround for when `krel` issue with release notes that start with backticks [issue incoming] #### Which issue(s) this PR fixes: <!-- *Automatically closes linked issue when PR is merged. Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. Fixes # or None --> #### Special notes for your reviewer: similar issue fixed in the [past](kubernetes#1974)
AnaMMedina21
added a commit
to AnaMMedina21/sig-release
that referenced
this pull request
Nov 15, 2022
<!-- Thanks for sending a pull request! Here are some tips for you: - If this is your first time, please read our contributor guidelines: https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide - Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request. For reference on required PR/issue labels, read here: https://git.k8s.io/community/contributors/devel/sig-release/release.md#issuepr-kind-label - If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews - If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests --> #### What type of PR is this: cleanup, Part 2 of PR kubernetes#2073 (issue #2753) <!-- Add one of the following kinds: /kind cleanup /kind documentation /kind feature /kind design --> #### What this PR does / why we need it: temp fix/workaround for when `krel` issue with release notes that start with backticks [issue incoming] #### Which issue(s) this PR fixes: <!-- *Automatically closes linked issue when PR is merged. Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. Fixes # or None --> #### Special notes for your reviewer: similar issue fixed in the [past](kubernetes#1974)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
/kind bug
What this PR does / why we need it:
Getting error:
decoding note map: yaml: line 3: found character that cannot start any tokenwhile generating release notes for v1.25.0-alpha.3Which issue(s) this PR fixes:
Special notes for your reviewer: