Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new tool: patch release cherry pick notification #2432

Closed
wants to merge 3 commits into from
Closed

Add new tool: patch release cherry pick notification #2432

wants to merge 3 commits into from

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Feb 16, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:

This is a tool that will run in a prow job and uses the https://raw.githubusercontent.com/kubernetes/website/main/data/releases/schedule.yaml published with the patch releases and will notify when the cherry pick deadline is close by sending an email to the k-dev mailing list.

Opened as WIP to collect feedback and see what we can improve

After approval and merge, will add the prow job to run the tool

/assign @saschagrunert @puerco @xmudrii @Verolop @justaugustus
cc @kubernetes/release-engineering

Which issue(s) this PR fixes:

Fixes partially #2174

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Add new tool: patch release cherry pick notification

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 16, 2022
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Feb 16, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 16, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 16, 2022
@cpanato cpanato force-pushed the patch-notify branch 3 times, most recently from 406aa33 to be70916 Compare February 16, 2022 15:37
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 16, 2022
@cpanato cpanato force-pushed the patch-notify branch 3 times, most recently from 39d4512 to 06d3137 Compare February 16, 2022 15:44
saschagrunert
saschagrunert reviewed Feb 17, 2022
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the idea of the early notification 👍

cmd/patch-release-notify/cmd/root.go Outdated Show resolved Hide resolved
@puerco
Copy link
Member

puerco commented May 10, 2022

/assign

@justaugustus
Copy link
Member

Feel free to reassign me when this is ready!
/unassign

saschagrunert
saschagrunert reviewed Jan 18, 2023
View reviewed changes
cmd/patch-release-notify/README.md
The simplest way to install the `patch-release-notify` CLI is via `go get`:

```
$ go get k8s.io/release/cmd/patch-release-notify
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$ go get k8s.io/release/cmd/patch-release-notify
$ go install k8s.io/release/cmd/patch-release-notify@latest

I think go get is deprecated for installing binaries.

cmd/patch-release-notify/cmd/root.go
@@ -0,0 +1,295 @@
/*
Copyright 2022 The Kubernetes Authors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Copyright 2022 The Kubernetes Authors.
Copyright 2023 The Kubernetes Authors.

cmd/patch-release-notify/cmd/root.go
&opts.dayToalert,
dayToalertFlag,
3,
"day to before the deadline to send the notification. Defaults to 3 days.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the deadline is on Friday's, we probably wanna adjust the deadline to the previous Monday. So 4 days?

cmd/patch-release-notify/cmd/root.go
)

var requiredFlags = []string{
schedulePathFlag,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we point that to a default remote location without requiring the path to be locally available?

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cpanato cpanato reopened this Feb 17, 2023
@cpanato
Copy link
Member Author

cpanato commented Feb 17, 2023

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Feb 17, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 18, 2023
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 19, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 18, 2023
@cpanato
Copy link
Member Author

cpanato commented Jun 19, 2023

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jun 19, 2023
@justaugustus
Copy link
Member

@cpanato – should we resurrect this PR?

@cpanato
Copy link
Member Author

cpanato commented Nov 19, 2023

@justaugustus yes!! i know we are discussing which email service to use, so I would like to align that. do you have any updates @jimangel @ameukam? what is the email service?

then I can update this PR and we can move forward

@jimangel
Copy link
Member

what is the email service?

The solution I proposed is for manual sending (releng folks cutting releases). This seems like it's attempting to be a more automated solution? If so, we'd need to evaluate a different bulk-sending service like @ameukam mentioned.

TL;DR: I don't think there's a solution yet for automated emails.

We also might be able to modify my solution to use an offline / refresh token, but then we'd have to figure out which account we'd want to authorize to allow "sending email on behalf."

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 17, 2024
@cpanato
Copy link
Member Author

cpanato commented Feb 17, 2024

/remove-lifecycle remove

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 18, 2024
@cpanato
Copy link
Member Author

cpanato commented Mar 19, 2024

/remove-lifecycle rotten

working on that

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Mar 19, 2024
@cpanato
Copy link
Member Author

cpanato commented May 30, 2024

closing in favor of #3627

@cpanato cpanato closed this May 30, 2024
@cpanato cpanato deleted the patch-notify branch May 30, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert left review comments

@palnabarun palnabarun palnabarun left review comments

@jimangel jimangel Awaiting requested review from jimangel

@onlydole onlydole Awaiting requested review from onlydole

Assignees

@saschagrunert saschagrunert

@Verolop Verolop

@puerco puerco

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@cpanato @k8s-ci-robot @puerco @justaugustus @k8s-triage-robot @jimangel @saschagrunert @palnabarun @Verolop @xmudrii