Skip to content

Add members 2019-05-03 #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 4, 2019
Merged

Add members 2019-05-03 #788

merged 2 commits into from
May 4, 2019

Conversation

@mrbobbytables
Copy link
Member

@mrbobbytables mrbobbytables commented May 4, 2019

fixes #777
fixes #786

/area github-membership

@k8s-ci-robot k8s-ci-robot added area/github-membership Requesting membership in a Kubernetes GitHub Organization or Team cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 4, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 4, 2019
This was referenced May 4, 2019
Closed
Closed
@cblecker
Copy link
Member

cblecker commented May 4, 2019

/lgtm
/approve

@cblecker cblecker closed this May 4, 2019
@nikhita
Copy link
Member

nikhita commented May 4, 2019

@cblecker looking at the timestamps, I'm assuming this was closed because of accidentally hitting the "close and comment" button :P

/reopen

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 4, 2019

@nikhita: Reopened this PR.

In response to this:

@cblecker looking at the timestamps, I'm assuming this was closed because of accidentally hitting the "close and comment" button :P

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this May 4, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2019
nikhita
nikhita approved these changes May 4, 2019
View reviewed changes
Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 4, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, mrbobbytables, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b257ca7 into kubernetes:master May 4, 2019
@cblecker
Copy link
Member

cblecker commented May 4, 2019

🤦‍♂ yes, that's my bad. thanks for catching, @nikhita

@mrbobbytables mrbobbytables deleted the add-members-2019-05-03 branch May 10, 2019 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikhita nikhita nikhita approved these changes

@calebamiles calebamiles Awaiting requested review from calebamiles

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@nikhita nikhita

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-membership Requesting membership in a Kubernetes GitHub Organization or Team cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

REQUEST: New membership for cwdsuzhou REQUEST: New membership for Ethyling

4 participants

@mrbobbytables @cblecker @nikhita @k8s-ci-robot