Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes/sig-cluster-lifecycle: update kubeadm teams #3056

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

neolit123
Copy link
Member

@neolit123 neolit123 commented Oct 25, 2021

Include only the current active approver roster in
maintainers:
https://github.com/kubernetes/kubeadm/blob/cb2f0aef8f780525d0364590fc9a19a04576edea/OWNERS#L4-L6

Include only myself as admin. Admin access is currently
only required for the master->main default branch rename
which is planned for 1.23. Admin access is not required for anything
else and maintainers have sufficient control.

kubernetes/kubeadm#2589

Include only the current active approver roster in
maintainers:
https://github.com/kubernetes/kubernetes/blob/770bc047406120130c00cd7c1b0f944903ed53e0/cmd/kubeadm/OWNERS#L4-L6https://github.com/kubernetes/kubeadm/blob/cb2f0aef8f780525d0364590fc9a19a04576edea/OWNERS#L4-L6

Include only myself as admin. Admin access is currently
only required for the master->main default branch rename
which is planned for 1.23. Admin access is not required for anything
else and maintainers have sufficient control.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 25, 2021
@neolit123
Copy link
Member Author

/sig cluster-lifecycle
/kind cleanup

@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 25, 2021
@k8s-ci-robot k8s-ci-robot added area/github-management Issues or PRs related to GitHub Management subproject approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 25, 2021
@neolit123
Copy link
Member Author

/cc @fabriziopandini @vincepri
looking for LGTM

Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2d4b42b into kubernetes:main Oct 25, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants