Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --node option for command ip and ssh-key #9873

Merged

Conversation

lingsamuel
Copy link
Contributor

Provides options -n, --node for command ip and ssh-key while minikube now support multi-node.

Example:

$ minikube ip -n m03
192.168.39.112
$ minikube ip -n m02
192.168.39.195
$ minikube ip -n m05

❌  Exiting due to GUEST_NODE_RETRIEVE: Could not find node m05

😿  If the above advice does not help, please let us know: 
👉  https://github.com/kubernetes/minikube/issues/new/choose

$ minikube ssh-key -n m05

❌  Exiting due to GUEST_NODE_RETRIEVE: Could not find node m05

😿  If the above advice does not help, please let us know: 
👉  https://github.com/kubernetes/minikube/issues/new/choose

$ minikube ssh-key -n m03
/home/lingsamuel/.minikube/machines/minikube-m03/id_rsa
$ minikube ip
192.168.39.13
$ minikube ssh-key
/home/lingsamuel/.minikube/machines/minikube/id_rsa

@k8s-ci-robot
Copy link
Contributor

Hi @lingsamuel. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 7, 2020
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@lingsamuel lingsamuel force-pushed the node-param-for-ip-and-ssh-key branch 2 times, most recently from bd922be to 1a1afa9 Compare December 7, 2020 07:12
@lingsamuel
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@lingsamuel: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lingsamuel
Copy link
Contributor Author

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 9, 2020
@afbjorklund
Copy link
Collaborator

afbjorklund commented Dec 9, 2020

Looks promising, eventually we will need the same feature also for the ssh-host (host keys) once it is included

Edit: ssh and ssh-host already had --node parameter

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 9, 2020
@afbjorklund afbjorklund removed the kind/feature Categorizes issue or PR as related to a new feature. label Dec 9, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 9873): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9873/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9873/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 9873): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9873/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9873/minikube: exec format error

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lingsamuel, tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2020
@tstromberg tstromberg merged commit fdab252 into kubernetes:master Dec 16, 2020
@lingsamuel lingsamuel deleted the node-param-for-ip-and-ssh-key branch December 31, 2020 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants