Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spinner at preparing Kubernetes... #9855

Merged
merged 33 commits into from
Dec 11, 2020
Merged
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
df37c78
change config func call
ruben-baez-seagull-com Dec 2, 2020
2e3e0ab
add new method to print spinner
ruben-baez-seagull-com Dec 2, 2020
7a0a2b0
remove break line in spinner line
ruben-baez-seagull-com Dec 2, 2020
65dc5b8
add spinner library to mod
ruben-baez-seagull-com Dec 2, 2020
88947d6
add break line in windows case
ruben-baez-seagull-com Dec 4, 2020
ead02fd
remove unnecesary file
ruben-baez-seagull-com Dec 4, 2020
f37a4aa
remove windows break line
ruben-baez-seagull-com Dec 4, 2020
6e37ffb
change spinner module version
ruben-baez-seagull-com Dec 4, 2020
994ff36
restore break line
ruben-baez-seagull-com Dec 4, 2020
b6ee8f2
remove old versions of the spinner
ruben-baez-seagull-com Dec 4, 2020
33b6e9a
add spinner param in step func
ruben-baez-seagull-com Dec 7, 2020
f7abca6
remove comment line
ruben-baez-seagull-com Dec 7, 2020
23dc03c
fix delete unittest
ruben-baez-seagull-com Dec 7, 2020
64f4895
fix lint if statement
ruben-baez-seagull-com Dec 7, 2020
32bb174
fix lint goimports
ruben-baez-seagull-com Dec 7, 2020
7a9979b
restore go sum
ruben-baez-seagull-com Dec 7, 2020
6b89930
add older lines in go sum
ruben-baez-seagull-com Dec 8, 2020
b330cdb
Merge branch 'master' into w/add-spinner
ruben-baez-seagull-com Dec 8, 2020
a763e05
change bool to second parameter
ruben-baez-seagull-com Dec 8, 2020
e09dcaa
Merge branch 'w/add-spinner' of https://github.com/alonyb/minikube in…
ruben-baez-seagull-com Dec 8, 2020
8d11d8b
Merge branch 'master' of https://github.com/alonyb/minikube into w/ad…
ruben-baez-seagull-com Dec 9, 2020
291ea78
fix repo with upstream
ruben-baez-seagull-com Dec 9, 2020
73ea4f2
add comment and fix bool param
ruben-baez-seagull-com Dec 9, 2020
032b43c
fix lint
ruben-baez-seagull-com Dec 9, 2020
e45b42f
fix unittest
ruben-baez-seagull-com Dec 9, 2020
c24eda6
change false to constant
ruben-baez-seagull-com Dec 9, 2020
42aac91
remove bool var from String func
ruben-baez-seagull-com Dec 9, 2020
e7ca292
change more false by constant
ruben-baez-seagull-com Dec 9, 2020
f729145
fix lint
ruben-baez-seagull-com Dec 9, 2020
277e096
remove param && add spin bool to style enum
ruben-baez-seagull-com Dec 10, 2020
d474058
restore unittest
ruben-baez-seagull-com Dec 10, 2020
8ee8989
move spinner character const to style
ruben-baez-seagull-com Dec 10, 2020
2d80cfc
fix lint
ruben-baez-seagull-com Dec 10, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/minikube/cmd/stop.go
Original file line number Diff line number Diff line change
@@ -102,7 +102,7 @@ func runStop(cmd *cobra.Command, args []string) {
schedule.KillExisting(profilesToStop)
if cancelScheduledStop {
register.Reg.SetStep(register.Done)
out.Step(style.Stopped, `All existing scheduled stops cancelled`)
out.Step(style.Stopped, false, `All existing scheduled stops cancelled`)
return
}