Ability to use a custom TLS certificate with the Ingress #9797
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
|
Can one of the admins verify this patch? |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test ? |
|
@msedzins: The following commands are available to trigger jobs:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-minikube-platform-tests |
|
/test all |
|
@msedzins: No jobs can be run with
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
@msedzins: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Hi, there are 4 tests failing, completely not related to the functionality introduced in this PR, Could someone tell me if I should do anything about this? |
There was a problem hiding this comment.
thanks for this PR @msedzins
do you mind adding in the PR description the output after this PR using this new feature?
add a short tutotiral in our website
"how to use custom TLS cert with ingress addon on minikube"
with an example usage of this feature
Tutorial added
k8s-ci-robot
added
size/M
|
@medyagh Hi, I've added tutorial and extended PR description. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, msedzins The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Description of functionality can be found here: #9335
How to use it
$ minikube addons configure ingress
-- Enter custom cert(format is "namespace/secret"): kube-system/mkcert
✅ ingress was successfully configured
Enable addons plugin (or disable and then enable if already enabled):
$ minikube addons disable ingress
$ minikube addons enable ingress
Expected result
After running:
$ kubectl -n kube-system get deployment ingress-nginx-controller -o yaml
There will be one extra parameter added to nginx (the last one):
spec:
containers:
- args:
- /nginx-ingress-controller
- --configmap=$(POD_NAMESPACE)/nginx-load-balancer-conf
- --report-node-internal-ip-address
- --tcp-services-configmap=$(POD_NAMESPACE)/tcp-services
- --udp-services-configmap=$(POD_NAMESPACE)/udp-services
- --validating-webhook=:8443
- --validating-webhook-certificate=/usr/local/certificates/cert
- --validating-webhook-key=/usr/local/certificates/key
- --default-ssl-certificate=kube-system/mkcert