Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker-env: "reload" dockerd service first before "restart" to avoid restarting apiserver container #9756

Merged
merged 4 commits into from
Nov 24, 2020
Merged

docker-env: "reload" dockerd service first before "restart" to avoid restarting apiserver container #9756

merged 4 commits into from
Nov 24, 2020

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Nov 20, 2020 •
edited
Loading

will attempt to fix this
#9691

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 20, 2020
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 20, 2020
@medyagh medyagh changed the title try reload dockerd first before restart docker-env: try reload dockerd first before restart Nov 20, 2020
@medyagh
Copy link
Member Author

medyagh commented Nov 21, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 21, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 9756): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9756/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9756/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 9756): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9756/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9756/minikube: exec format error

@blueelvis blueelvis mentioned this pull request Nov 21, 2020
Merged
@medyagh medyagh changed the title docker-env: try reload dockerd first before restart docker-env: reload dockerd first before restart. Nov 23, 2020
@medyagh medyagh changed the title docker-env: reload dockerd first before restart. docker-env: "reload" dockerd service first before "restart" Nov 23, 2020
@medyagh medyagh changed the title docker-env: "reload" dockerd service first before "restart" docker-env: "reload" dockerd service first before "restart" to avoid restarting apiserver container Nov 23, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [medyagh,sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh medyagh merged commit 2dc88c5 into kubernetes:master Nov 24, 2020
@medyagh medyagh deleted the docker_env_restart branch March 2, 2021 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharifelgamal sharifelgamal sharifelgamal approved these changes

@RA489 RA489 Awaiting requested review from RA489

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@medyagh @minikube-pr-bot @k8s-ci-robot @sharifelgamal