Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove template dependency in addons #9748

Merged
merged 16 commits into from
Nov 23, 2020
Merged

Remove template dependency in addons #9748

merged 16 commits into from
Nov 23, 2020

Conversation

alonyb
Copy link

@alonyb alonyb commented Nov 19, 2020 •
edited
Loading

This PR is to:

  1. Fix logviewer addon, same bug as Fix registry-creds addon failure with ImageRepository #9733
  2. An improvement in the solution, with this, there will no longer be a dependency on the boolean variable isTemplate, in this case all templates will always be rendered. With this there will no longer be problems that folks have or don't have to use the boolean variable.

WIP:

  1. Change all yaml files into tmpl format.
  2. Test that all addons work

logviewer output err:
image

Now all addons are in tmpl format, yaml files have been removed.
The output of the addons that were changed now still works:

Screen Shot 2020-11-21 at 18 16 22

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 19, 2020
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 20, 2020
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 21, 2020
@alonyb alonyb changed the title WIP Remove template dependency in addons Remove template dependency in addons Nov 21, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 21, 2020
medyagh
medyagh approved these changes Nov 23, 2020
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @alonyb for fixing this bug

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alonyb, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2020
@medyagh medyagh merged commit f5478a4 into kubernetes:master Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@prasadkatti prasadkatti Awaiting requested review from prasadkatti

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alonyb @k8s-ci-robot @medyagh @ruben-baez-seagull-com