Pass environment to docker commands

[4c0n]

Ran into some issues trying to use minikube on systems that do not use the unix socket to connect to the docker daemon.
The issue at hand is that the docker CLI is configured only through the use of arguments or environmental variables. Even when using contexts there is no other way to select a context.

This change allows the environmental variables to be passed along with the docker commands, so that the client can run in the same manner that it would as when it would be executed by the user (especially when configured using environmental variables).

To make this happen, I had to modify the behavior of always clearing the docker daemon related env vars within the application context to only unsetting them, when the log line actually states that it will.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @4c0n!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @4c0n. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 4c0n
To complete the pull request process, please assign priyawadhwa after the PR has been reviewed.
You can assign the PR to them by writing /assign @priyawadhwa in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[minikube-bot]

Can one of the admins verify this patch?

[medyagh]

@4c0n thanks for this PR, have you looked athis PR #9510

this Pr might need to be added after that PR

[4c0n]

@medyagh Thanks for pointing that PR out. I haven't looked at it before. It seems aimed to achieve a similar goal. Although for me this simple solution works. It also seems partially included in the other PR though. Not in a conflicting kind of way.

[4c0n]

I signed it

[k8s-ci-robot]

@4c0n: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[medyagh]

@4c0n we recenetly added support for non-default docker environments, do u mind checking if latest minikube on head has fixed the problem you are describing ?

[medyagh]

@4c0n does this PR do what you wanted ? #9510

[tstromberg]

Do you mind resolving the merge conflicts and addressing @medyagh 's comments?

[4c0n]

@medyagh Yes it looks like the change in this PR is also included/addressed in that PR. Closing this one.