Add --network flag to select docker network to run with docker driver #9538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
size/M
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
|
kvm2 Driver |
tstromberg
approved these changes
Oct 23, 2020
medyagh
requested changes
Oct 23, 2020
|
kvm2 Driver Times for Minikube (PR 9538): 62.5s 56.8s 58.1s Averages Time Per Log docker Driver Times for Minikube (PR 9538): 28.3s 29.6s 28.2s Averages Time Per Log |
k8s-ci-robot
added
the
needs-rebase
k8s-ci-robot
removed
the
needs-rebase
|
kvm2 Driver Times for Minikube (PR 9538): 61.2s 59.7s 60.9s Averages Time Per Log docker Driver Times for Minikube (PR 9538): 29.0s 28.8s 28.8s Averages Time Per Log |
priyawadhwa
changed the title
|
@medyagh now that we have the MTU fix in, do you think it's worth it to add this flag? I'm worried it won't be particularly useful and we're just adding another flag option to |
|
kvm2 Driver Times for Minikube (PR 9538): 62.6s 61.1s 60.0s Averages Time Per Log docker Driver Times for Minikube (PR 9538): 29.3s 28.7s 29.8s Averages Time Per Log |
Travis tests have failedHey @priyawadhwa, 1st Buildmake testTravisBuddy Request Identifier: 91cddcc0-17d6-11eb-bc4d-2726ba7bdf50 |
|
kvm2 Driver Times for Minikube (PR 9538): 59.4s 62.4s 59.4s Averages Time Per Log docker Driver Times for Minikube (PR 9538): 29.7s 31.4s 28.0s Averages Time Per Log |
I think this flag would still be useful, particularly for cases where Docker is running remotely. I had wanted to recommend this flag to a WSL2 user running into networking problems today :( |
medyagh
requested changes
Oct 30, 2020
k8s-ci-robot
added
the
needs-rebase
|
kvm2 Driver Times for Minikube (PR 9538): 63.2s 61.2s 63.1s Averages Time Per Log docker Driver Times for Minikube (PR 9538): 28.5s 29.2s 29.5s Averages Time Per Log |
medyagh
requested changes
Dec 8, 2020
|
@priyawadhwa - do you mind resolving the conflict and looking at the failing test @medyagh mentioned? |
k8s-ci-robot
added
the
needs-rebase
k8s-ci-robot
removed
the
needs-rebase
|
kvm2 Driver Times for Minikube (PR 9538): 58.9s 58.6s 58.6s Averages Time Per Log docker Driver Times for Minikube (PR 9538): 24.7s 23.1s 23.2s Averages Time Per Log |
|
/retest-this-please |
medyagh
requested changes
Dec 22, 2020
|
kvm2 Driver Times for Minikube (PR 9538): 59.9s 61.6s 59.7s Averages Time Per Log docker Driver Times for Minikube (PR 9538): 25.3s 25.2s 24.1s Averages Time Per Log |
|
kvm2 Driver Times for Minikube (PR 9538): 58.6s 61.7s 62.9s Averages Time Per Log docker Driver Times for Minikube (PR 9538): 24.4s 25.0s 25.8s Averages Time Per Log |
|
/ok-to-test |
medyagh
requested changes
Dec 23, 2020
cmd/minikube/cmd/start_flags.go
Outdated
| @@ -293,12 +295,17 @@ func generateClusterConfig(cmd *cobra.Command, existing *config.ClusterConfig, k | |||
| out.WarningT("With --network-plugin=cni, you will need to provide your own CNI. See --cni flag as a user-friendly alternative") | |||
| } | |||
|
|
|||
| if !driver.IsKIC(drvName) && viper.GetString(network) != "" { | |||
| out.WarningT("--network flag is only valid with the docker driver, it will be ignored") | |||
added 2 commits
December 23, 2020 14:02
|
kvm2 Driver Times for Minikube (PR 9538): 60.1s 59.7s 61.5s Averages Time Per Log docker Driver Times for Minikube (PR 9538): 25.9s 26.2s 25.6s Averages Time Per Log |
|
thank you for this great PR @priyawadhwa |
medyagh
approved these changes
Dec 24, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, priyawadhwa, tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can now select the network they want to run the docker driver with. If left empty, we will default to creating a new network so that static IP changes can be maintained. Users can go back to using default network by running: