-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable TCP Path MTU Discovery when an ICMP black hole is detected #9537
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: priyawadhwa, tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't it better to be added to both ISO and kicbase at same time?
this PR would need a new kic-base image, that I believe has some other changes, for a point release we might wanna avoid that since we have not tested the head kicbase
Done. |
Codecov Report
@@ Coverage Diff @@
## master #9537 +/- ##
==========================================
+ Coverage 29.08% 29.11% +0.03%
==========================================
Files 171 172 +1
Lines 10443 10461 +18
==========================================
+ Hits 3037 3046 +9
- Misses 6983 6990 +7
- Partials 423 425 +2
|
Partial fix for #9528 - the longer-term fix will come from #9530
This lets
docker pull
work when the network MTU is misconfigured. There are no apparent downsides to this approach, as best as I can tell. Here's the documentation from https://www.kernel.org/doc/Documentation/networking/ip-sysctl.txtNOTE That
tcp_base_mss
defaults to 1024. I believe that 1 is the best default going forward.I can confirm that this allows
minikube ssh "docker pull golang:1.15"
to work properly on Cloud Shell.Old behavior
New behavior