Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade buildroot and kernel minor version #9523

Merged
merged 2 commits into from
Oct 30, 2020

Conversation

afbjorklund
Copy link
Collaborator

@afbjorklund afbjorklund commented Oct 22, 2020

http://lists.busybox.net/pipermail/buildroot/2020-October/294451.html

Our configuration still has a 4.19 kernel, rather than the default 5.4 kernel

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 22, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2020
@afbjorklund afbjorklund changed the title Upgrade buildroot minor version WIP: Upgrade buildroot minor version Oct 22, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 22, 2020
@afbjorklund
Copy link
Collaborator Author

afbjorklund commented Oct 22, 2020

Would be nice to get #9394 in before this one, to restore the kernel config along with bumping the minor version

I used the same kernel version as buildroot did (for 4.19), but I'm not sure how much it matters (150 vs 152 etc).

@afbjorklund afbjorklund changed the title WIP: Upgrade buildroot minor version Upgrade buildroot minor version Oct 22, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 22, 2020
@afbjorklund
Copy link
Collaborator Author

Did some basic smoke testing locally, seemed OK

🐳 Preparing Kubernetes v1.19.2 on Docker 19.03.13 ..

🎁 Preparing Kubernetes v1.19.2 on CRI-O 1.18.3 ...

Linux minikube 4.19.150 #1 SMP Thu Oct 22 21:56:19 CEST 2020 x86_64 GNU/Linux

@codecov-io
Copy link

Codecov Report

Merging #9523 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9523   +/-   ##
=======================================
  Coverage   29.11%   29.11%           
=======================================
  Files         172      172           
  Lines       10461    10461           
=======================================
  Hits         3046     3046           
  Misses       6990     6990           
  Partials      425      425           

@afbjorklund afbjorklund changed the title Upgrade buildroot minor version Upgrade buildroot and kernel minor version Oct 23, 2020
@medyagh medyagh merged commit a7b8f20 into kubernetes:master Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants