-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new --wait component "kubelet" #9459
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #9459 +/- ##
=======================================
Coverage 29.05% 29.05%
=======================================
Files 171 171
Lines 10444 10443 -1
=======================================
Hits 3034 3034
+ Misses 6988 6987 -1
Partials 422 422
|
/ok-to-test |
kvm2 Driver Times for Minikube (PR 9459): 60.4s 60.9s 60.1s Averages Time Per Log
docker Driver Times for Minikube (PR 9459): 28.3s 29.4s 29.0s Averages Time Per Log
|
1bc0626
to
ad83c72
Compare
Travis tests have failedHey @medyagh, 1st Buildmake test
2nd Buildmake test
3rd Buildmake
TravisBuddy Request Identifier: b779d800-0da6-11eb-9111-f326d0cb7f09 |
kvm2 Driver Times for Minikube (PR 9459): 57.7s 60.4s 58.4s Averages Time Per Log
docker Driver Times for Minikube (PR 9459): 26.8s 28.4s 27.2s Averages Time Per Log
|
Travis tests have failedHey @medyagh, 1st Buildmake test
2nd Buildmake test
3rd Buildmake
TravisBuddy Request Identifier: debb5d60-0da8-11eb-9111-f326d0cb7f09 |
Travis tests have failedHey @medyagh, 1st Buildmake test
2nd Buildmake test
3rd Buildmake
TravisBuddy Request Identifier: 291afa00-0da9-11eb-9111-f326d0cb7f09 |
kvm2 Driver Times for Minikube (PR 9459): 60.1s 59.1s 60.0s Averages Time Per Log
docker Driver Times for Minikube (PR 9459): 27.5s 29.2s 27.4s Averages Time Per Log
|
kvm2 Driver Times for Minikube (PR 9459): 60.4s 64.4s 62.3s Averages Time Per Log
docker Driver Times for Minikube (PR 9459): 29.6s 26.8s 27.5s Averages Time Per Log
|
kvm2 Driver Times for Minikube (PR 9459): 59.8s 63.5s 62.7s Averages Time Per Log
docker Driver Times for Minikube (PR 9459): 27.1s 28.1s 27.4s Averages Time Per Log
|
while this does NOT fix the issue #9456 it might help to get to the bottom of it.
this adds a new wait component which is not enabled by default.
if user passes --wait=all it will wait for everything including kubelet