Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump helm-tiller addon to v2.16.12 #9444

Merged
merged 1 commit into from
Oct 15, 2020
Merged

bump helm-tiller addon to v2.16.12 #9444

merged 1 commit into from
Oct 15, 2020

Conversation

govargo
Copy link
Contributor

@govargo govargo commented Oct 12, 2020

What type of PR is this?

/area addons

What this PR does / why we need it:

This PR bump up helm-tiller addon's image v2.16.8 to v2.16.12.
This version has security improvement and fixed issues of helm-tiller.

Which issue(s) this PR fixes:

Fixes #9443

Does this PR introduce a user-facing change?

Yes.
This image bumpup includes helm2 fixed issues.
https://github.com/helm/helm/releases/tag/v2.16.12

Before

image: gcr.io/kubernetes-helm/tiller:v2.16.8

After

image: gcr.io/kubernetes-helm/tiller:v2.16.12

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 12, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @govargo. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: govargo
To complete the pull request process, please assign priyawadhwa after the PR has been reviewed.
You can assign the PR to them by writing /assign @priyawadhwa in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 12, 2020
@govargo
Copy link
Contributor Author

govargo commented Oct 12, 2020

/assign @priyawadhwa

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@priyawadhwa
Copy link

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 12, 2020
@kubernetes kubernetes deleted a comment from minikube-pr-bot Oct 12, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: 66.3s 61.5s 62.2s
Average time for minikube: 63.3s

Times for Minikube (PR 9444): 61.6s 62.9s 59.7s
Average time for Minikube (PR 9444): 61.4s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9444) |
+--------------------------------+----------+--------------------+
| * minikube v1.14.0-beta.0 on   | 0.0s     | 0.0s               |
| Debian 9.11                    |          |                    |
| * Using the kvm2 driver based  | 0.0s     | 0.0s               |
| on user configuration          |          |                    |
| * Starting control plane node  | 0.0s     | 0.0s               |
| minikube in cluster minikube   |          |                    |
| * Creating kvm2 VM (CPUs=2,    | 36.6s    | 35.4s              |
| Memory=3700MB, Disk=20000MB)   |          |                    |
| ...                            |          |                    |
| * Preparing Kubernetes v1.19.2 | 24.5s    | 23.9s              |
| on Docker 19.03.12 ...         |          |                    |
| * Verifying Kubernetes         | 1.7s     | 1.6s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.2s     | 0.5s               |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
|                                | 0.7s     | 0.0s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

docker Driver
Times for minikube: 30.5s 28.7s 29.6s
Average time for minikube: 29.6s

Times for Minikube (PR 9444): 29.9s 30.1s 28.8s
Average time for Minikube (PR 9444): 29.6s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9444) |
+--------------------------------+----------+--------------------+
| * minikube v1.14.0-beta.0 on   | 0.2s     | 0.2s               |
| Debian 9.11                    |          |                    |
| * Using the docker driver      | 0.1s     | 0.1s               |
| based on user configuration    |          |                    |
| * Starting control plane node  | 0.1s     | 0.1s               |
| minikube in cluster minikube   |          |                    |
| * Creating docker container    | 9.3s     | 9.3s               |
| (CPUs=2, Memory=3700MB) ...    |          |                    |
| * Preparing Kubernetes v1.19.2 | 18.7s    | 18.6s              |
| on Docker 19.03.8 ...          |          |                    |
| * Verifying Kubernetes         | 1.1s     | 1.2s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.1s     | 0.1s               |
| storage-provisioner,           |          |                    |
| default-storageclass           |          |                    |
|                                | 0.1s     | 0.0s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

@medyagh medyagh merged commit 6153beb into kubernetes:master Oct 15, 2020
@govargo govargo deleted the update-helm2.16.12 branch February 13, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump helm-tiller addon v2.16.12
6 participants