-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing the controller name in ingress-nginx-controller patch #9413
Conversation
updated ingress-nginx-controller-patch.yaml spec: template: spec: containers: - name: controller ports: - containerPort: 6379 hostPort: 6379
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @nprajilesh! |
Hi @nprajilesh. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nprajilesh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #9413 +/- ##
=======================================
Coverage 29.20% 29.20%
=======================================
Files 171 171
Lines 10447 10447
=======================================
Hits 3051 3051
Misses 6972 6972
Partials 424 424 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nprajilesh thank you for this PR,
do you mind sharing the before/after this PR output ? to see if this PR fixed the bug ?
@medyagh I've updated the PR description with before/after details. |
Description
fixes #9354
fixing the container name in ingress-nginx-controller-patch.yaml ( Ref : ingress-dp.yaml )
How Has This Been Tested?
Issue Reproduced
after applying the fix