Added deprecation warning for --network-plugin=cni

[kadern0]

Signed-off-by: Pablo Caderno [email protected]
Fixes #8445

@tstromberg please have a look and let me know if the message is OK.

Before start message:

./out/minikube start -p test --network-plugin=cni 
😄  [test] minikube v1.13.1 on Ubuntu 20.04
    ▪ MINIKUBE_ACTIVE_DOCKERD=minikube
✨  Automatically selected the docker driver. Other choices: kvm2, virtualbox
👍  Starting control plane node test in cluster test
🔥  Creating docker container (CPUs=2, Memory=3900MB) ...
🐳  Preparing Kubernetes v1.19.2 on Docker 19.03.8 ...
🔎  Verifying Kubernetes components...
🌟  Enabled addons: storage-provisioner, default-storageclass

❗  /usr/local/bin/kubectl is version 1.17.2, which may have incompatibilites with Kubernetes 1.19.2.
💡  Want kubectl v1.19.2? Try 'minikube kubectl -- get pods -A'
🏄  Done! kubectl is now configured to use "test" by default

After start message:

 ./out/minikube start -p test --network-plugin=cni 
😄  [test] minikube v1.13.1 on Ubuntu 20.04
    ▪ MINIKUBE_ACTIVE_DOCKERD=minikube
✨  Automatically selected the docker driver. Other choices: kvm2, virtualbox
❗  Found deprecated --network-plugin=cni flag (new flag: --cni), setting --cni=auto if not already set
👍  Starting control plane node test in cluster test
🔥  Creating docker container (CPUs=2, Memory=3900MB) ...
🐳  Preparing Kubernetes v1.19.2 on Docker 19.03.8 ...
🔎  Verifying Kubernetes components...
🌟  Enabled addons: storage-provisioner, default-storageclass

❗  /usr/local/bin/kubectl is version 1.17.2, which may have incompatibilites with Kubernetes 1.19.2.
💡  Want kubectl v1.19.2? Try 'minikube kubectl -- get pods -A'
🏄  Done! kubectl is now configured to use "test" by default

[k8s-ci-robot]

Hi @kadern0. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[minikube-bot]

Can one of the admins verify this patch?

[tstromberg]

I misspoke in the original bug report, the actual deprecated flag was --enable-default-cni, checked above this. --network-plugin is still a necessary evil for some cases.

Could you change the warning to say something more like:

With --network-plugin=cni, you will need to provide your own CNI. See --cni flag as a user-friendly alternative

I would minikube not suddenly change the behavior of existing users of --network-plugin=cni if it can be avoided.

[kadern0]

I've just updated the code.

[tstromberg]

Thank you!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadern0, tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tstromberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment