Base kicbase directly on ubuntu, without kindbase #9330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove local things from kind, replace with packages. Use the "clean-install" script for a nicer Dockerfile.
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/L
This is for reference, to be able to combine them
Also fix the 19.10 comment, it hadn't been updated
Base kicbase directly on ubuntu, without kindbase Move all the files that are still copied and used Avoid installing software only to be deleted later The entrypoint had already been forked since earlier
Codecov Report
@@ Coverage Diff @@
## master #9330 +/- ##
=======================================
Coverage 29.38% 29.38%
=======================================
Files 170 170
Lines 10334 10334
=======================================
Hits 3037 3037
Misses 6875 6875
Partials 422 422 |
afbjorklund
force-pushed
the
kicbase-ubuntu
branch
from
bcb01bb
to
8a18334
Compare
medyagh
requested changes
Sep 29, 2020
medyagh
approved these changes
Sep 29, 2020
This was referenced Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the all-in-one version, that includes all the changes from PR #9135 and PR #9225 - but without the interim steps.
Closes #7788