Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure gcp-auth addon can be enabled on startup #9318

Merged
merged 10 commits into from
Sep 29, 2020

Conversation

sharifelgamal
Copy link
Collaborator

@sharifelgamal sharifelgamal commented Sep 24, 2020

This PR makes sure the gcp-auth addons can be enabled on startup safely by making it the last addon enabled. It also fixes a documentation issue in an error message and makes sure we never apply the webhook to the internal kube-system pods.

Fixes #9208
Fixes #9215

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 24, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2020
@TravisBuddy
Copy link

Travis tests have failed

Hey @sharifelgamal,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
MINIKUBE_LDFLAGS="-X k8s.io/minikube/pkg/version.version=v1.13.1 -X k8s.io/minikube/pkg/version.isoVersion=v1.13.1 -X k8s.io/minikube/pkg/version.isoPath=minikube/iso -X k8s.io/minikube/pkg/version.gitCommitID="00cd45467a8f5f24a0e944ebeb6a31912bb31aec" -X k8s.io/minikube/pkg/version.storageProvisionerVersion=v3" ./test.sh
= make lint =============================================================
golangci/golangci-lint info checking GitHub for tag 'v1.30.0'
golangci/golangci-lint info found version: 1.30.0 for v1.30.0/linux/amd64
golangci/golangci-lint info installed out/linters/golangci-lint
pkg/addons/addons.go:327:2: ineffectual assignment to `err` (ineffassign)
	err := verifyAddonStatusInternal(cc, name, val, "gcp-auth")
	^
Makefile:433: recipe for target 'lint-ci' failed
make[1]: *** [lint-ci] Error 1
= go mod ================================================================
ok
= boilerplate ===========================================================
ok
Makefile:314: recipe for target 'test' failed
make: *** [test] Error 4
TravisBuddy Request Identifier: c0eef750-fe95-11ea-803e-573615702161

for _, a := range toEnableList {
// Run the gcp-auth addon last to make sure everything else is up
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still a race condition, as addon enablement does not block until the pods are available.

I think you can remove this special case by naming a failurePolicy for the webhook instead, so that it fails open if unavailable:

https://kubernetes.io/docs/reference/access-authn-authz/extensible-admission-controllers/#failure-policy

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For an example test case: /out/minikube start --addons=dashboard --addons=efk --addons=freshpod --addons=istio --addons=istio-provisioner --addons=olm --memory=16384 --driver=hyperkit

That said, it is a race condition, and may not be easy to trigger. Better to just fail open.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding the failurePolicy is a good idea just in general, but this code isn't supposed to eliminate the race, just reduce it as much as possible. In my testing it seems to be very effectively at precisely that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that failurePolicy is in place, can this ordering code be safely removed?

The nice thing about failurePolicy is that it also eliminates the race condition when you use minikube addons enable while another pod is scheduling.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so just in my empirical testing, the race condition still happens fairly often without this code, which makes me think I don't quite understand what's happening here.

- key: name
operator: NotIn
values:
- kube-system
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to filtering kube-system out.

@TravisBuddy
Copy link

Travis tests have failed

Hey @sharifelgamal,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
MINIKUBE_LDFLAGS="-X k8s.io/minikube/pkg/version.version=v1.13.1 -X k8s.io/minikube/pkg/version.isoVersion=v1.13.1 -X k8s.io/minikube/pkg/version.isoPath=minikube/iso -X k8s.io/minikube/pkg/version.gitCommitID="b35c638cb9940cba335a299c86db6c61764ad29a" -X k8s.io/minikube/pkg/version.storageProvisionerVersion=v3" ./test.sh
= schema_check ==========================================================
go: downloading github.com/xeipuuv/gojsonschema v0.0.0-20180618132009-1d523034197f
go: downloading github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415
go: downloading github.com/xeipuuv/gojsonpointer v0.0.0-20180127040702-4e3ac2762d5f
ok
= go test ===============================================================
go: downloading github.com/blang/semver v3.5.0+incompatible
go: downloading github.com/machine-drivers/machine v0.7.1-0.20200810185219-7d42fed1b770
go: downloading golang.org/x/sync v0.0.0-20200317015054-43a5402ce75a
go: downloading k8s.io/apimachinery v0.17.3
go: downloading k8s.io/api v0.17.3
go: downloading k8s.io/kubernetes v1.18.5
go: downloading k8s.io/client-go v0.17.3
go: downloading github.com/afbjorklund/go-containerregistry v0.0.0-20200902152226-fbad78ec2813
go: downloading github.com/pkg/errors v0.9.1
go: downloading golang.org/x/text v0.3.2
go: downloading k8s.io/klog v1.0.0
go: downloading github.com/gogo/protobuf v1.3.1
go: downloading github.com/spf13/cobra v1.0.0
go: downloading golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d
go: downloading github.com/shirou/gopsutil v2.18.12+incompatible
go: downloading github.com/docker/docker v1.4.2-0.20190924003213-a8608b5b67c7
go: downloading github.com/machine-drivers/docker-machine-driver-vmware v0.1.1
go: downloading github.com/juju/clock v0.0.0-20190205081909-9c5c9712527c
go: downloading github.com/juju/mutex v0.0.0-20180619145857-d21b13acf4bf
go: downloading google.golang.org/api v0.25.0
go: downloading golang.org/x/exp v0.0.0-20200224162631-6cc2880d07d6
go: downloading k8s.io/kubectl v0.17.3
go: downloading gopkg.in/yaml.v2 v2.3.0
go: downloading github.com/google/uuid v1.1.1
go: downloading cloud.google.com/go v0.57.0
go: downloading k8s.io/utils v0.0.0-20200324210504-a9aa75ae1b89
go: downloading github.com/otiai10/copy v1.0.2
go: downloading github.com/docker/cli v0.0.0-20200303162255-7d407207c304
go: downloading golang.org/x/time v0.0.0-20200416051211-89c76fbcd5d1
go: downloading github.com/mitchellh/go-ps v0.0.0-20190716172923-621e5597135b
go: downloading github.com/google/gofuzz v1.1.0
go: downloading github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
go: downloading github.com/cloudevents/sdk-go/v2 v2.1.0
go: downloading github.com/phayes/freeport v0.0.0-20180830031419-95f893ade6f2
go: downloading github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51
go: downloading github.com/cenkalti/backoff v2.2.1+incompatible
go: downloading cloud.google.com/go/storage v1.8.0
go: downloading go.opencensus.io v0.22.3
go: downloading github.com/modern-go/reflect2 v1.0.1
go: downloading github.com/spf13/viper v1.7.0
go: downloading github.com/subosito/gotenv v1.2.0
go: downloading github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
go: downloading github.com/juju/errors v0.0.0-20190806202954-0232dcc7464d
go: downloading golang.org/x/sys v0.0.0-20200523222454-059865788121
go: downloading github.com/pkg/browser v0.0.0-20160118053552-9302be274faa
go: downloading go.uber.org/zap v1.10.0
go: downloading gopkg.in/inf.v0 v0.9.1
go: downloading github.com/intel-go/cpuid v0.0.0-20181003105527-1a4a6f06a1c6
go: downloading golang.org/x/net v0.0.0-20200520182314-0ba52f642ac2
go: downloading github.com/spf13/jwalterweatherman v1.1.0
go: downloading github.com/lightstep/tracecontext.go v0.0.0-20181129014701-1757c391b1ac
go: downloading github.com/spf13/afero v1.2.2
go: downloading github.com/google/slowjam v0.0.0-20200530021616-df27e642fe7b
go: downloading sigs.k8s.io/yaml v1.2.0
go: downloading golang.org/x/crypto v0.0.0-20200510223506-06a226fb4e37
go: downloading github.com/russross/blackfriday v1.5.3-0.20200218234912-41c5fccfd6f6
go: downloading github.com/cloudfoundry-attic/jibber_jabber v0.0.0-20151120183258-bcc4c8345a21
go: downloading github.com/magiconair/properties v1.8.1
go: downloading google.golang.org/genproto v0.0.0-20200527145253-8367513e4ece
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading github.com/opencontainers/go-digest v1.0.0-rc1
go: downloading github.com/pkg/profile v0.0.0-20161223203901-3a8809bd8a80
go: downloading github.com/hashicorp/hcl v1.0.0
go: downloading go.uber.org/atomic v1.4.0
go: downloading github.com/docker/go-connections v0.4.0
go: downloading go.uber.org/multierr v1.1.0
go: downloading github.com/spf13/cast v1.3.1
go: downloading github.com/cpuguy83/go-md2man v1.0.10
go: downloading github.com/cpuguy83/go-md2man/v2 v2.0.0
go: downloading github.com/golang/protobuf v1.4.2
go: downloading google.golang.org/grpc v1.29.1
go: downloading gopkg.in/ini.v1 v1.56.0
go: downloading github.com/docker/distribution v2.7.1+incompatible
go: downloading github.com/russross/blackfriday/v2 v2.0.1
go: downloading github.com/MakeNowJust/heredoc v0.0.0-20170808103936-bb23615498cd
go: downloading github.com/hooklift/iso9660 v0.0.0-20170318115843-1cf07e5970d8
go: downloading github.com/pelletier/go-toml v1.8.0
go: downloading github.com/spf13/pflag v1.0.5
go: downloading github.com/libvirt/libvirt-go v3.4.0+incompatible
go: downloading github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e
go: downloading github.com/hashicorp/golang-lru v0.5.3
go: downloading github.com/c4milo/gotoolkit v0.0.0-20170318115440-bcc06269efa9
go: downloading github.com/opencontainers/image-spec v1.0.1
go: downloading github.com/golang-collections/collections v0.0.0-20130729185459-604e922904d3
go: downloading github.com/cheggaaa/pb v1.0.27
go: downloading github.com/cheggaaa/pb/v3 v3.0.1
go: downloading google.golang.org/protobuf v1.24.0
go: downloading github.com/docker/go-units v0.4.0
go: downloading github.com/google/go-cmp v0.4.1
go: downloading github.com/googleapis/gnostic v0.3.0
go: downloading github.com/fsnotify/fsnotify v1.4.9
go: downloading github.com/olekukonko/tablewriter v0.0.4
go: downloading github.com/sayboras/dockerclient v1.0.0
go: downloading github.com/fatih/color v1.9.0
go: downloading github.com/json-iterator/go v1.1.9
go: downloading github.com/shurcooL/sanitized_anchor_name v1.0.0
go: downloading github.com/sirupsen/logrus v1.6.0
go: downloading github.com/VividCortex/ewma v1.1.1
go: downloading k8s.io/component-base v0.17.3
go: downloading k8s.io/cluster-bootstrap v0.17.3
go: downloading sigs.k8s.io/sig-storage-lib-external-provisioner v4.0.0+incompatible
go: downloading github.com/mattn/go-isatty v0.0.12
go: downloading github.com/mattn/go-colorable v0.1.6
go: downloading github.com/afbjorklund/go-getter v1.4.1-0.20190910175809-eb9f6c26742c
go: downloading github.com/imdario/mergo v0.3.9
go: downloading github.com/containerd/containerd v1.3.1-0.20191213020239-082f7e3aed57
go: downloading sigs.k8s.io/sig-storage-lib-external-provisioner/v5 v5.0.0
go: downloading github.com/googleapis/gax-go v2.0.2+incompatible
go: downloading github.com/mitchellh/go-wordwrap v1.0.0
go: downloading github.com/docker/docker-credential-helpers v0.6.3
go: downloading github.com/prometheus/client_golang v1.4.1
go: downloading k8s.io/kube-openapi v0.0.0-20200410145947-61e04a5be9a6
go: downloading github.com/googleapis/gax-go/v2 v2.0.5
go: downloading github.com/mitchellh/mapstructure v1.3.1
go: downloading github.com/aws/aws-sdk-go v1.31.6
go: downloading github.com/docker/spdystream v0.0.0-20160310174837-449fdfce4d96
go: downloading github.com/mattn/go-runewidth v0.0.7
go: downloading github.com/bgentry/go-netrc v0.0.0-20140422174119-9fd32a8b3d3d
go: downloading github.com/prometheus/procfs v0.0.8
go: downloading github.com/prometheus/common v0.9.1
go: downloading github.com/beorn7/perks v1.0.1
go: downloading github.com/prometheus/client_model v0.2.0
go: downloading github.com/hashicorp/go-cleanhttp v0.5.1
go: downloading github.com/mitchellh/go-testing-interface v1.0.0
go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.1
go: downloading github.com/hashicorp/go-version v1.2.0
go: downloading github.com/ulikunitz/xz v0.5.7
go: downloading github.com/cespare/xxhash v1.1.0
go: downloading github.com/hashicorp/go-safetemp v1.0.0
go: downloading github.com/miekg/dns v1.1.27
go: downloading github.com/mitchellh/go-homedir v1.1.0
go: downloading github.com/cespare/xxhash/v2 v2.1.1
go: downloading github.com/jmespath/go-jmespath v0.3.0
go: downloading github.com/pmezard/go-difflib v1.0.0
go: downloading github.com/evanphx/json-patch v4.5.0+incompatible
go: downloading golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543
ok  	k8s.io/minikube/cmd/minikube/cmd	6.883s	coverage: 18.5% of statements
ok  	k8s.io/minikube/cmd/minikube/cmd/config	0.048s	coverage: 21.5% of statements
ok  	k8s.io/minikube/pkg/addons	0.049s	coverage: 49.2% of statements
ok  	k8s.io/minikube/pkg/drivers	0.017s	coverage: 19.6% of statements
ok  	k8s.io/minikube/pkg/drivers/hyperkit	0.019s	coverage: 77.3% of statements
ok  	k8s.io/minikube/pkg/drivers/kic/oci	0.015s	coverage: 7.1% of statements
ok  	k8s.io/minikube/pkg/drivers/kvm	0.021s	coverage: 2.3% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper	0.718s	coverage: 55.7% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/bsutil	0.131s	coverage: 62.4% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/bsutil/ktmpl	0.008s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/images	0.009s	coverage: 82.0% of statements
ok  	k8s.io/minikube/pkg/minikube/cluster	0.076s	coverage: 15.3% of statements
ok  	k8s.io/minikube/pkg/minikube/command	0.031s	coverage: 4.2% of statements
ok  	k8s.io/minikube/pkg/minikube/config	0.145s	coverage: 68.1% of statements
ok  	k8s.io/minikube/pkg/minikube/cruntime	0.098s	coverage: 36.7% of statements
ok  	k8s.io/minikube/pkg/minikube/docker	0.031s	coverage: 20.8% of statements
ok  	k8s.io/minikube/pkg/minikube/driver	0.035s	coverage: 33.9% of statements
ok  	k8s.io/minikube/pkg/minikube/extract	0.008s	coverage: 58.8% of statements
ok  	k8s.io/minikube/pkg/minikube/image	0.023s	coverage: 3.0% of statements
ok  	k8s.io/minikube/pkg/minikube/kubeconfig	0.028s	coverage: 81.2% of statements
ok  	k8s.io/minikube/pkg/minikube/localpath	0.017s	coverage: 49.3% of statements
ok  	k8s.io/minikube/pkg/minikube/logs	0.038s	coverage: 1.3% of statements
ok  	k8s.io/minikube/pkg/minikube/machine	1.095s	coverage: 36.2% of statements
ok  	k8s.io/minikube/pkg/minikube/mustload	0.103s	coverage: 10.5% of statements
ok  	k8s.io/minikube/pkg/minikube/notify	0.046s	coverage: 92.9% of statements
ok  	k8s.io/minikube/pkg/minikube/out	0.076s	coverage: 66.0% of statements
ok  	k8s.io/minikube/pkg/minikube/out/register	0.030s	coverage: 54.5% of statements
2020/09/25 16:30:28 Running: [sh -c echo hi && sleep 3 && echo hey && sleep 1]...
--- FAIL: TestTimeCommandLogs (4.00s)
    logs_test.go:42: expected log "hi" to take more time than it actually did. got 2.999284149, expected > 3
FAIL
coverage: 21.1% of statements
FAIL	k8s.io/minikube/pkg/minikube/perf	4.013s
ok  	k8s.io/minikube/pkg/minikube/proxy	0.012s	coverage: 68.7% of statements
ok  	k8s.io/minikube/pkg/minikube/reason	0.009s	coverage: 80.0% of statements
ok  	k8s.io/minikube/pkg/minikube/registry	0.013s	coverage: 75.5% of statements
ok  	k8s.io/minikube/pkg/minikube/service	0.073s	coverage: 84.2% of statements
ok  	k8s.io/minikube/pkg/minikube/shell	0.012s	coverage: 97.1% of statements
ok  	k8s.io/minikube/pkg/minikube/storageclass	0.038s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/style	0.002s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/sysinit	0.038s	coverage: 6.5% of statements
ok  	k8s.io/minikube/pkg/minikube/translate	0.009s	coverage: 10.5% of statements
ok  	k8s.io/minikube/pkg/minikube/tunnel	1.653s	coverage: 64.2% of statements
ok  	k8s.io/minikube/pkg/util	0.599s	coverage: 77.9% of statements
ok  	k8s.io/minikube/pkg/util/lock	0.007s	coverage: 22.2% of statements
ok  	k8s.io/minikube/pkg/util/retry	0.003s	coverage: 0.0% of statements
FAIL
Makefile:314: recipe for target 'test' failed
make: *** [test] Error 32
TravisBuddy Request Identifier: 8eaad860-ff4c-11ea-b444-3dcc0bd866ab

@sharifelgamal
Copy link
Collaborator Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 25, 2020
@kubernetes kubernetes deleted a comment from minikube-pr-bot Sep 25, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: 62.2s 61.5s 58.7s
Average time for minikube: 60.8s

Times for Minikube (PR 9318): 60.1s 59.7s 60.3s
Average time for Minikube (PR 9318): 60.0s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9318) |
+--------------------------------+----------+--------------------+
| * minikube v1.13.1 on Debian   | 0.1s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the kvm2 driver based  | 0.0s     | 0.0s               |
| on user configuration          |          |                    |
| * Starting control plane node  | 0.0s     | 0.0s               |
| minikube in cluster minikube   |          |                    |
| * Creating kvm2 VM (CPUs=2,    | 35.8s    | 35.1s              |
| Memory=3700MB, Disk=20000MB)   |          |                    |
| ...                            |          |                    |
| * Preparing Kubernetes v1.19.2 | 23.0s    | 22.9s              |
| on Docker 19.03.12 ...         |          |                    |
| * Verifying Kubernetes         | 1.5s     | 1.6s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.3s     |                    |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
|                                | 0.0s     | 0.3s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

docker Driver
Times for minikube: 29.7s 30.0s 28.8s
Average time for minikube: 29.5s

Times for Minikube (PR 9318): 30.2s 28.4s 29.0s
Average time for Minikube (PR 9318): 29.2s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9318) |
+--------------------------------+----------+--------------------+
| * minikube v1.13.1 on Debian   | 0.1s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the docker driver      | 0.2s     | 0.2s               |
| based on user configuration    |          |                    |
| * Starting control plane node  | 0.1s     | 0.1s               |
| minikube in cluster minikube   |          |                    |
| * Creating docker container    | 8.7s     | 8.7s               |
| (CPUs=2, Memory=3700MB) ...    |          |                    |
| * Preparing Kubernetes v1.19.2 | 19.4s    | 18.9s              |
| on Docker 19.03.8 ...          |          |                    |
| * Verifying Kubernetes         | 1.0s     | 1.2s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.1s     |                    |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
|                                | 0.0s     | 0.0s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: 62.2s 59.7s 61.3s
Average time for minikube: 61.1s

Times for Minikube (PR 9318): 59.3s 59.0s 59.0s
Average time for Minikube (PR 9318): 59.1s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9318) |
+--------------------------------+----------+--------------------+
| * minikube v1.13.1 on Debian   | 0.1s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the kvm2 driver based  | 0.0s     | 0.0s               |
| on user configuration          |          |                    |
| * Starting control plane node  | 0.0s     | 0.0s               |
| minikube in cluster minikube   |          |                    |
| * Creating kvm2 VM (CPUs=2,    | 35.2s    | 35.2s              |
| Memory=3700MB, Disk=20000MB)   |          |                    |
| ...                            |          |                    |
| * Preparing Kubernetes v1.19.2 | 23.4s    | 22.1s              |
| on Docker 19.03.12 ...         |          |                    |
| * Verifying Kubernetes         | 1.6s     | 1.7s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.7s     |                    |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
|                                | 0.0s     | 0.0s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

docker Driver
Times for minikube: 30.5s 28.2s 28.2s
Average time for minikube: 28.9s

Times for Minikube (PR 9318): 28.5s 28.2s 28.3s
Average time for Minikube (PR 9318): 28.4s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9318) |
+--------------------------------+----------+--------------------+
| * minikube v1.13.1 on Debian   | 0.1s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the docker driver      | 0.2s     | 0.2s               |
| based on user configuration    |          |                    |
| * Starting control plane node  | 0.1s     | 0.1s               |
| minikube in cluster minikube   |          |                    |
| * Creating docker container    | 8.7s     | 8.5s               |
| (CPUs=2, Memory=3700MB) ...    |          |                    |
| * Preparing Kubernetes v1.19.2 | 18.7s    | 18.3s              |
| on Docker 19.03.8 ...          |          |                    |
| * Verifying Kubernetes         | 1.1s     | 1.1s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.1s     |                    |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
|                                | 0.0s     | 0.0s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

@sharifelgamal
Copy link
Collaborator Author

/ok-to-test

@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: 64.8s 61.9s 59.1s
Average time for minikube: 61.9s

Times for Minikube (PR 9318): 59.4s 61.5s 60.2s
Average time for Minikube (PR 9318): 60.4s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9318) |
+--------------------------------+----------+--------------------+
| * minikube v1.13.1 on Debian   | 0.1s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the kvm2 driver based  | 0.0s     | 0.0s               |
| on user configuration          |          |                    |
| * Starting control plane node  | 0.0s     | 0.0s               |
| minikube in cluster minikube   |          |                    |
| * Creating kvm2 VM (CPUs=2,    | 35.6s    | 35.1s              |
| Memory=3700MB, Disk=20000MB)   |          |                    |
| ...                            |          |                    |
| * Preparing Kubernetes v1.19.2 | 24.5s    | 23.1s              |
| on Docker 19.03.12 ...         |          |                    |
| * Verifying Kubernetes         | 1.6s     | 1.7s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.1s     |                    |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
|                                | 0.0s     | 0.3s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

docker Driver
Times for minikube: 30.2s 29.0s 31.8s
Average time for minikube: 30.3s

Times for Minikube (PR 9318): 29.7s 28.4s 31.6s
Average time for Minikube (PR 9318): 29.9s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9318) |
+--------------------------------+----------+--------------------+
| * minikube v1.13.1 on Debian   | 0.1s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the docker driver      | 0.2s     | 0.2s               |
| based on user configuration    |          |                    |
| * Starting control plane node  | 0.1s     | 0.1s               |
| minikube in cluster minikube   |          |                    |
| * Creating docker container    | 8.8s     | 8.7s               |
| (CPUs=2, Memory=3700MB) ...    |          |                    |
| * Preparing Kubernetes v1.19.2 | 20.2s    | 19.5s              |
| on Docker 19.03.8 ...          |          |                    |
| * Verifying Kubernetes         | 0.9s     | 1.2s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.1s     |                    |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
|                                | 0.0s     | 0.0s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

@TravisBuddy
Copy link

Travis tests have failed

Hey @sharifelgamal,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
MINIKUBE_LDFLAGS="-X k8s.io/minikube/pkg/version.version=v1.13.1 -X k8s.io/minikube/pkg/version.isoVersion=v1.13.1 -X k8s.io/minikube/pkg/version.isoPath=minikube/iso -X k8s.io/minikube/pkg/version.gitCommitID="131e36c31f8b937147abcb083a0b85a51b5ec9a1" -X k8s.io/minikube/pkg/version.storageProvisionerVersion=v3" ./test.sh
= schema_check ==========================================================
go: downloading github.com/xeipuuv/gojsonschema v0.0.0-20180618132009-1d523034197f
go: downloading github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415
go: downloading github.com/xeipuuv/gojsonpointer v0.0.0-20180127040702-4e3ac2762d5f
ok
= go test ===============================================================
go: downloading github.com/machine-drivers/machine v0.7.1-0.20200810185219-7d42fed1b770
go: downloading golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d
go: downloading github.com/pkg/profile v0.0.0-20161223203901-3a8809bd8a80
go: downloading k8s.io/client-go v0.17.3
go: downloading github.com/google/go-github v17.0.0+incompatible
go: downloading golang.org/x/exp v0.0.0-20200224162631-6cc2880d07d6
go: downloading github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
go: downloading k8s.io/api v0.17.3
go: downloading k8s.io/apimachinery v0.17.3
go: downloading golang.org/x/crypto v0.0.0-20200510223506-06a226fb4e37
go: downloading github.com/pkg/errors v0.9.1
go: downloading golang.org/x/sync v0.0.0-20200317015054-43a5402ce75a
go: downloading github.com/mattn/go-isatty v0.0.12
go: downloading cloud.google.com/go v0.57.0
go: downloading github.com/juju/mutex v0.0.0-20180619145857-d21b13acf4bf
go: downloading github.com/afbjorklund/go-containerregistry v0.0.0-20200902152226-fbad78ec2813
go: downloading github.com/spf13/cobra v1.0.0
go: downloading golang.org/x/net v0.0.0-20200520182314-0ba52f642ac2
go: downloading github.com/spf13/viper v1.7.0
go: downloading google.golang.org/api v0.25.0
go: downloading github.com/shirou/gopsutil v2.18.12+incompatible
go: downloading github.com/cheggaaa/pb v1.0.27
go: downloading github.com/juju/errors v0.0.0-20190806202954-0232dcc7464d
go: downloading golang.org/x/sys v0.0.0-20200523222454-059865788121
go: downloading github.com/cheggaaa/pb/v3 v3.0.1
go: downloading github.com/opencontainers/go-digest v1.0.0-rc1
go: downloading k8s.io/klog v1.0.0
go: downloading github.com/mitchellh/mapstructure v1.3.1
go: downloading github.com/spf13/afero v1.2.2
go: downloading cloud.google.com/go/storage v1.8.0
go: downloading k8s.io/kubectl v0.17.3
go: downloading github.com/afbjorklund/go-getter v1.4.1-0.20190910175809-eb9f6c26742c
go: downloading github.com/hooklift/iso9660 v0.0.0-20170318115843-1cf07e5970d8
go: downloading github.com/olekukonko/tablewriter v0.0.4
go: downloading github.com/hashicorp/hcl v1.0.0
go: downloading github.com/docker/docker v1.4.2-0.20190924003213-a8608b5b67c7
go: downloading github.com/intel-go/cpuid v0.0.0-20181003105527-1a4a6f06a1c6
go: downloading github.com/VividCortex/ewma v1.1.1
go: downloading gopkg.in/inf.v0 v0.9.1
go: downloading github.com/gogo/protobuf v1.3.1
go: downloading github.com/imdario/mergo v0.3.9
go: downloading github.com/sayboras/dockerclient v1.0.0
go: downloading github.com/mitchellh/go-ps v0.0.0-20190716172923-621e5597135b
go: downloading github.com/golang-collections/collections v0.0.0-20130729185459-604e922904d3
go: downloading github.com/hashicorp/go-safetemp v1.0.0
go: downloading github.com/googleapis/gnostic v0.3.0
go: downloading gopkg.in/ini.v1 v1.56.0
go: downloading github.com/otiai10/copy v1.0.2
go: downloading k8s.io/kubernetes v1.18.5
go: downloading github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51
go: downloading github.com/aws/aws-sdk-go v1.31.6
go: downloading google.golang.org/genproto v0.0.0-20200527145253-8367513e4ece
go: downloading k8s.io/utils v0.0.0-20200324210504-a9aa75ae1b89
go: downloading sigs.k8s.io/yaml v1.2.0
go: downloading github.com/hashicorp/go-version v1.2.0
go: downloading github.com/c4milo/gotoolkit v0.0.0-20170318115440-bcc06269efa9
go: downloading github.com/bgentry/go-netrc v0.0.0-20140422174119-9fd32a8b3d3d
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading github.com/fsnotify/fsnotify v1.4.9
go: downloading github.com/machine-drivers/docker-machine-driver-vmware v0.1.1
go: downloading github.com/docker/go-units v0.4.0
go: downloading github.com/mitchellh/go-homedir v1.1.0
go: downloading github.com/modern-go/reflect2 v1.0.1
go: downloading github.com/pkg/browser v0.0.0-20160118053552-9302be274faa
go: downloading github.com/subosito/gotenv v1.2.0
go: downloading github.com/golang/protobuf v1.4.2
go: downloading github.com/google/uuid v1.1.1
go: downloading github.com/hashicorp/go-cleanhttp v0.5.1
go: downloading golang.org/x/text v0.3.2
go: downloading github.com/MakeNowJust/heredoc v0.0.0-20170808103936-bb23615498cd
go: downloading github.com/pelletier/go-toml v1.8.0
go: downloading github.com/spf13/jwalterweatherman v1.1.0
go: downloading github.com/mitchellh/go-testing-interface v1.0.0
go: downloading google.golang.org/protobuf v1.24.0
go: downloading github.com/docker/cli v0.0.0-20200303162255-7d407207c304
go: downloading github.com/google/gofuzz v1.1.0
go: downloading github.com/fatih/color v1.9.0
go: downloading github.com/docker/go-connections v0.4.0
go: downloading github.com/ulikunitz/xz v0.5.7
go: downloading go.opencensus.io v0.22.3
go: downloading github.com/magiconair/properties v1.8.1
go: downloading golang.org/x/time v0.0.0-20200416051211-89c76fbcd5d1
go: downloading github.com/cenkalti/backoff v2.2.1+incompatible
go: downloading github.com/googleapis/gax-go v2.0.2+incompatible
go: downloading github.com/googleapis/gax-go/v2 v2.0.5
go: downloading google.golang.org/grpc v1.29.1
go: downloading github.com/google/slowjam v0.0.0-20200530021616-df27e642fe7b
go: downloading github.com/google/go-querystring v1.0.0
go: downloading github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
go: downloading github.com/cloudevents/sdk-go/v2 v2.1.0
go: downloading github.com/opencontainers/image-spec v1.0.1
go: downloading github.com/json-iterator/go v1.1.9
go: downloading k8s.io/cluster-bootstrap v0.17.3
go: downloading github.com/docker/distribution v2.7.1+incompatible
go: downloading github.com/mattn/go-colorable v0.1.6
go: downloading github.com/phayes/freeport v0.0.0-20180830031419-95f893ade6f2
go: downloading github.com/sirupsen/logrus v1.6.0
go: downloading github.com/juju/clock v0.0.0-20190205081909-9c5c9712527c
go: downloading gopkg.in/yaml.v2 v2.3.0
go: downloading github.com/russross/blackfriday v1.5.3-0.20200218234912-41c5fccfd6f6
go: downloading go.uber.org/zap v1.10.0
go: downloading github.com/containerd/containerd v1.3.1-0.20191213020239-082f7e3aed57
go: downloading sigs.k8s.io/sig-storage-lib-external-provisioner v4.0.0+incompatible
go: downloading github.com/mattn/go-runewidth v0.0.7
go: downloading github.com/spf13/cast v1.3.1
go: downloading github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e
go: downloading github.com/mitchellh/go-wordwrap v1.0.0
go: downloading github.com/hashicorp/golang-lru v0.5.3
go: downloading k8s.io/component-base v0.17.3
go: downloading sigs.k8s.io/sig-storage-lib-external-provisioner/v5 v5.0.0
go: downloading github.com/spf13/pflag v1.0.5
go: downloading github.com/docker/docker-credential-helpers v0.6.3
go: downloading github.com/cpuguy83/go-md2man v1.0.10
go: downloading github.com/cpuguy83/go-md2man/v2 v2.0.0
go: downloading github.com/lightstep/tracecontext.go v0.0.0-20181129014701-1757c391b1ac
go: downloading github.com/blang/semver v3.5.0+incompatible
go: downloading github.com/libvirt/libvirt-go v3.4.0+incompatible
go: downloading github.com/prometheus/client_golang v1.4.1
go: downloading github.com/russross/blackfriday/v2 v2.0.1
go: downloading github.com/cloudfoundry-attic/jibber_jabber v0.0.0-20151120183258-bcc4c8345a21
go: downloading go.uber.org/multierr v1.1.0
go: downloading go.uber.org/atomic v1.4.0
go: downloading github.com/docker/spdystream v0.0.0-20160310174837-449fdfce4d96
go: downloading github.com/miekg/dns v1.1.27
go: downloading github.com/prometheus/client_model v0.2.0
go: downloading github.com/prometheus/common v0.9.1
go: downloading github.com/google/go-cmp v0.4.1
go: downloading github.com/cespare/xxhash v1.1.0
go: downloading k8s.io/kube-openapi v0.0.0-20200410145947-61e04a5be9a6
go: downloading github.com/shurcooL/sanitized_anchor_name v1.0.0
go: downloading github.com/jmespath/go-jmespath v0.3.0
go: downloading github.com/beorn7/perks v1.0.1
go: downloading github.com/prometheus/procfs v0.0.8
go: downloading github.com/cespare/xxhash/v2 v2.1.1
go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.1
go: downloading github.com/pmezard/go-difflib v1.0.0
go: downloading golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543
go: downloading github.com/evanphx/json-patch v4.5.0+incompatible
ok  	k8s.io/minikube/cmd/minikube/cmd	4.334s	coverage: 18.4% of statements
ok  	k8s.io/minikube/cmd/minikube/cmd/config	0.050s	coverage: 21.5% of statements
exit status 85
FAIL	k8s.io/minikube/pkg/addons	0.080s
ok  	k8s.io/minikube/pkg/drivers	0.008s	coverage: 19.6% of statements
ok  	k8s.io/minikube/pkg/drivers/hyperkit	0.005s	coverage: 77.3% of statements
ok  	k8s.io/minikube/pkg/drivers/kic/oci	0.017s	coverage: 7.1% of statements
ok  	k8s.io/minikube/pkg/drivers/kvm	0.028s	coverage: 2.3% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper	0.906s	coverage: 55.7% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/bsutil	0.101s	coverage: 62.4% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/bsutil/ktmpl	0.006s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/images	0.007s	coverage: 82.0% of statements
ok  	k8s.io/minikube/pkg/minikube/cluster	0.083s	coverage: 15.3% of statements
ok  	k8s.io/minikube/pkg/minikube/command	0.033s	coverage: 4.2% of statements
ok  	k8s.io/minikube/pkg/minikube/config	0.226s	coverage: 68.1% of statements
ok  	k8s.io/minikube/pkg/minikube/cruntime	0.057s	coverage: 36.7% of statements
ok  	k8s.io/minikube/pkg/minikube/docker	0.058s	coverage: 20.8% of statements
ok  	k8s.io/minikube/pkg/minikube/driver	0.027s	coverage: 33.9% of statements
ok  	k8s.io/minikube/pkg/minikube/extract	0.010s	coverage: 58.6% of statements
ok  	k8s.io/minikube/pkg/minikube/image	0.029s	coverage: 3.0% of statements
ok  	k8s.io/minikube/pkg/minikube/kubeconfig	0.031s	coverage: 81.2% of statements
ok  	k8s.io/minikube/pkg/minikube/localpath	0.022s	coverage: 49.3% of statements
ok  	k8s.io/minikube/pkg/minikube/logs	0.047s	coverage: 1.3% of statements
ok  	k8s.io/minikube/pkg/minikube/machine	1.095s	coverage: 35.9% of statements
ok  	k8s.io/minikube/pkg/minikube/mustload	0.060s	coverage: 10.5% of statements
ok  	k8s.io/minikube/pkg/minikube/notify	0.045s	coverage: 92.9% of statements
ok  	k8s.io/minikube/pkg/minikube/out	0.085s	coverage: 66.0% of statements
ok  	k8s.io/minikube/pkg/minikube/out/register	0.007s	coverage: 54.5% of statements
ok  	k8s.io/minikube/pkg/minikube/perf	4.031s	coverage: 21.1% of statements
ok  	k8s.io/minikube/pkg/minikube/proxy	0.012s	coverage: 68.7% of statements
ok  	k8s.io/minikube/pkg/minikube/reason	0.009s	coverage: 80.0% of statements
ok  	k8s.io/minikube/pkg/minikube/registry	0.011s	coverage: 75.5% of statements
ok  	k8s.io/minikube/pkg/minikube/service	0.095s	coverage: 84.2% of statements
ok  	k8s.io/minikube/pkg/minikube/shell	0.003s	coverage: 97.1% of statements
ok  	k8s.io/minikube/pkg/minikube/storageclass	0.035s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/style	0.002s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/sysinit	0.061s	coverage: 6.5% of statements
ok  	k8s.io/minikube/pkg/minikube/translate	0.019s	coverage: 10.5% of statements
ok  	k8s.io/minikube/pkg/minikube/tunnel	1.651s	coverage: 64.2% of statements
ok  	k8s.io/minikube/pkg/util	0.682s	coverage: 75.7% of statements
ok  	k8s.io/minikube/pkg/util/lock	0.004s	coverage: 22.2% of statements
ok  	k8s.io/minikube/pkg/util/retry	0.014s	coverage: 0.0% of statements
FAIL
Makefile:314: recipe for target 'test' failed
make: *** [test] Error 32
TravisBuddy Request Identifier: ee3cfa40-01c9-11eb-9be6-0d9634a5fbe7

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optoinally please add docs to addons contributors, if they want their addon to be defered...to be added to this lit

@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: 62.0s 66.4s 59.9s
Average time for minikube: 62.8s

Times for Minikube (PR 9318): 89.4s 243.2s 242.6s
Average time for Minikube (PR 9318): 191.7s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9318) |
+--------------------------------+----------+--------------------+
| * minikube v1.13.1 on Debian   | 0.2s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the kvm2 driver based  | 0.0s     | 0.0s               |
| on user configuration          |          |                    |
| * Starting control plane node  | 0.0s     | 0.0s               |
| minikube in cluster minikube   |          |                    |
| * Creating kvm2 VM (CPUs=2,    | 37.2s    | 35.2s              |
| Memory=3700MB, Disk=20000MB)   |          |                    |
| ...                            |          |                    |
| * Preparing Kubernetes v1.19.2 | 22.9s    | 23.6s              |
| on Docker 19.03.12 ...         |          |                    |
| * Verifying Kubernetes         | 1.6s     | 4.6s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.8s     |                    |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
|                                | 0.0s     | 0.0s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

docker Driver
Times for minikube: 33.3s 30.3s 30.5s
Average time for minikube: 31.4s

Times for Minikube (PR 9318): 211.4s 210.5s 210.3s
Average time for Minikube (PR 9318): 210.7s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9318) |
+--------------------------------+----------+--------------------+
| * minikube v1.13.1 on Debian   | 0.1s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the docker driver      | 0.2s     | 0.2s               |
| based on user configuration    |          |                    |
| * Starting control plane node  | 0.1s     | 0.1s               |
| minikube in cluster minikube   |          |                    |
| * Creating docker container    | 9.6s     | 8.8s               |
| (CPUs=2, Memory=3700MB) ...    |          |                    |
| * Preparing Kubernetes v1.19.2 | 20.2s    | 19.0s              |
| on Docker 19.03.8 ...          |          |                    |
| * Verifying Kubernetes         | 1.1s     | 2.5s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.1s     |                    |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
|                                | 0.0s     | 0.1s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: 63.6s 61.7s 59.1s
Average time for minikube: 61.5s

Times for Minikube (PR 9318): 240.8s 241.4s 240.2s
Average time for Minikube (PR 9318): 240.8s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9318) |
+--------------------------------+----------+--------------------+
| * minikube v1.13.1 on Debian   | 0.1s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the kvm2 driver based  | 0.0s     | 0.0s               |
| on user configuration          |          |                    |
| * Starting control plane node  | 0.0s     | 0.0s               |
| minikube in cluster minikube   |          |                    |
| * Creating kvm2 VM (CPUs=2,    | 36.2s    | 35.6s              |
| Memory=3700MB, Disk=20000MB)   |          |                    |
| ...                            |          |                    |
| * Preparing Kubernetes v1.19.2 | 23.3s    | 22.2s              |
| on Docker 19.03.12 ...         |          |                    |
| * Verifying Kubernetes         | 1.5s     | 2.8s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.4s     |                    |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
|                                | 0.0s     | 0.0s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

docker Driver
Times for minikube: 31.2s 28.5s 30.1s
Average time for minikube: 30.0s

Times for Minikube (PR 9318): 211.4s 210.8s 210.6s
Average time for Minikube (PR 9318): 210.9s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9318) |
+--------------------------------+----------+--------------------+
| * minikube v1.13.1 on Debian   | 0.1s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the docker driver      | 0.2s     | 0.2s               |
| based on user configuration    |          |                    |
| * Starting control plane node  | 0.1s     | 0.1s               |
| minikube in cluster minikube   |          |                    |
| * Creating docker container    | 9.1s     | 8.8s               |
| (CPUs=2, Memory=3700MB) ...    |          |                    |
| * Preparing Kubernetes v1.19.2 | 19.3s    | 19.4s              |
| on Docker 19.03.8 ...          |          |                    |
| * Verifying Kubernetes         | 1.0s     | 2.3s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.1s     |                    |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
|                                | 0.0s     | 180.0s             |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: 62.8s 60.9s 60.5s
Average time for minikube: 61.4s

Times for Minikube (PR 9318): 61.0s 61.8s 61.8s
Average time for Minikube (PR 9318): 61.5s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9318) |
+--------------------------------+----------+--------------------+
| * minikube v1.13.1 on Debian   | 0.1s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the kvm2 driver based  | 0.0s     | 0.0s               |
| on user configuration          |          |                    |
| * Starting control plane node  | 0.0s     | 0.0s               |
| minikube in cluster minikube   |          |                    |
| * Creating kvm2 VM (CPUs=2,    | 36.6s    | 35.8s              |
| Memory=3700MB, Disk=20000MB)   |          |                    |
| ...                            |          |                    |
| * Preparing Kubernetes v1.19.2 | 22.7s    | 23.8s              |
| on Docker 19.03.12 ...         |          |                    |
| * Verifying Kubernetes         | 1.5s     | 1.6s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.6s     |                    |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
|                                | 0.0s     | 0.0s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

docker Driver
Times for minikube: 30.9s 30.6s 30.5s
Average time for minikube: 30.7s

Times for Minikube (PR 9318): 29.6s 28.7s 29.8s
Average time for Minikube (PR 9318): 29.3s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9318) |
+--------------------------------+----------+--------------------+
| * minikube v1.13.1 on Debian   | 0.1s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the docker driver      | 0.2s     | 0.2s               |
| based on user configuration    |          |                    |
| * Starting control plane node  | 0.1s     | 0.1s               |
| minikube in cluster minikube   |          |                    |
| * Creating docker container    | 8.9s     | 8.8s               |
| (CPUs=2, Memory=3700MB) ...    |          |                    |
| * Preparing Kubernetes v1.19.2 | 20.3s    | 18.9s              |
| on Docker 19.03.8 ...          |          |                    |
| * Verifying Kubernetes         | 1.1s     | 1.1s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.1s     |                    |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
|                                | 0.0s     | 0.0s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

@sharifelgamal sharifelgamal merged commit ff051f9 into kubernetes:master Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
6 participants