fix mounting for docker driver in windows #9263

sharifelgamal · 2020-09-16T21:58:29Z

Accounts for C:\ being at the start of a Windows path.
Make sure to check for absolute path in the GUEST VM rather than the host.

Before

$ out/minikube start --mount
* minikube v1.13.0 on Microsoft Windows 10 Pro 10.0.18363 Build 18363
* Automatically selected the docker driver. Other choices: hyperv, virtualbox
* Starting control plane node minikube in cluster minikube
* Pulling base image ...
* Creating docker container (CPUs=2, Memory=4138MB) ...
! StartHost failed, but will try again: config: '/minikube-host' container path must be absolute
* Creating docker container (CPUs=2, Memory=4138MB) ...
* Failed to start docker container. Running "minikube delete" may fix it: config: '/minikube-host' container path must be absolute
! Startup with docker driver failed, trying with alternate driver hyperv: Failed to start host: config: '/minikube-host' container path must be absolute

After

$ out/minikube start --mount
* minikube v1.13.0 on Microsoft Windows 10 Pro 10.0.18363 Build 18363
* Automatically selected the docker driver. Other choices: hyperv, virtualbox
* Starting control plane node minikube in cluster minikube
* Creating docker container (CPUs=2, Memory=4138MB) ...
* Preparing Kubernetes v1.19.1 on Docker 19.03.8 ...
* Verifying Kubernetes components...
* Enabled addons: default-storageclass, storage-provisioner
* Done! kubectl is now configured to use "minikube" by default

Fixes #9216

k8s-ci-robot · 2020-09-16T22:00:00Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

TravisBuddy · 2020-09-16T22:04:54Z

Travis tests have failed

Hey @sharifelgamal,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test

PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
MINIKUBE_LDFLAGS="-X k8s.io/minikube/pkg/version.version=v1.13.0 -X k8s.io/minikube/pkg/version.isoVersion=v1.13.0 -X k8s.io/minikube/pkg/version.isoPath=minikube/iso -X k8s.io/minikube/pkg/version.gitCommitID="76a98f555dfed8af6e4134e785e99e3248484459" -X k8s.io/minikube/pkg/version.storageProvisionerVersion=v3" ./test.sh
= make lint =============================================================
golangci/golangci-lint info checking GitHub for tag 'v1.30.0'
golangci/golangci-lint info found version: 1.30.0 for v1.30.0/linux/amd64
golangci/golangci-lint info installed out/linters/golangci-lint
pkg/drivers/kic/oci/oci.go:110:1: cyclomatic complexity 31 of func `CreateContainerNode` is high (> 30) (gocyclo)
func CreateContainerNode(p CreateParams) error {
^
pkg/drivers/kic/oci/types.go:118:3: S1011: should replace loop with `fields = append(fields, f[2:]...)` (gosimple)
		for _, opt := range f[2:] {
		^
Makefile:433: recipe for target 'lint-ci' failed
make[1]: *** [lint-ci] Error 1
= go mod ================================================================
unused golang.org/x/exp
ok
= boilerplate ===========================================================
ok
Makefile:314: recipe for target 'test' failed
make: *** [test] Error 4

TravisBuddy Request Identifier: a4dee620-f868-11ea-8f9f-a900ee46d44b

TravisBuddy · 2020-09-16T23:11:30Z

Travis tests have failed

Hey @sharifelgamal,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test

PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
MINIKUBE_LDFLAGS="-X k8s.io/minikube/pkg/version.version=v1.13.0 -X k8s.io/minikube/pkg/version.isoVersion=v1.13.0 -X k8s.io/minikube/pkg/version.isoPath=minikube/iso -X k8s.io/minikube/pkg/version.gitCommitID="23743452ab073e20cc3764e50b95cbebc4968a25" -X k8s.io/minikube/pkg/version.storageProvisionerVersion=v3" ./test.sh
= make lint =============================================================
golangci/golangci-lint info checking GitHub for tag 'v1.30.0'
golangci/golangci-lint info found version: 1.30.0 for v1.30.0/linux/amd64
golangci/golangci-lint info installed out/linters/golangci-lint
pkg/drivers/kic/oci/oci.go:110:1: cyclomatic complexity 31 of func `CreateContainerNode` is high (> 30) (gocyclo)
func CreateContainerNode(p CreateParams) error {
^
Makefile:433: recipe for target 'lint-ci' failed
make[1]: *** [lint-ci] Error 1
= go mod ================================================================
ok
= boilerplate ===========================================================
ok
Makefile:314: recipe for target 'test' failed
make: *** [test] Error 4

TravisBuddy Request Identifier: f324ce90-f871-11ea-8f9f-a900ee46d44b

TravisBuddy · 2020-09-16T23:46:17Z

Travis tests have failed

Hey @sharifelgamal,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test

PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
MINIKUBE_LDFLAGS="-X k8s.io/minikube/pkg/version.version=v1.13.0 -X k8s.io/minikube/pkg/version.isoVersion=v1.13.0 -X k8s.io/minikube/pkg/version.isoPath=minikube/iso -X k8s.io/minikube/pkg/version.gitCommitID="3916f1068638008becf0823bea189b71f6cf0e79" -X k8s.io/minikube/pkg/version.storageProvisionerVersion=v3" ./test.sh
= make lint =============================================================
golangci/golangci-lint info checking GitHub for tag 'v1.30.0'
golangci/golangci-lint info found version: 1.30.0 for v1.30.0/linux/amd64
golangci/golangci-lint info installed out/linters/golangci-lint
pkg/drivers/kic/oci/oci.go:110:1: cyclomatic complexity 31 of func `CreateContainerNode` is high (> 30) (gocyclo)
func CreateContainerNode(p CreateParams) error {
^
Makefile:433: recipe for target 'lint-ci' failed
make[1]: *** [lint-ci] Error 1
= go mod ================================================================
ok
= boilerplate ===========================================================
ok
Makefile:314: recipe for target 'test' failed
make: *** [test] Error 4

TravisBuddy Request Identifier: cee2c960-f876-11ea-8f9f-a900ee46d44b

pkg/drivers/kic/oci/types.go

…mount

sharifelgamal · 2020-09-18T20:08:10Z

/ok-to-test

minikube-pr-bot · 2020-09-18T20:47:38Z

kvm2 Driver
Times for minikube: 65.2s 63.8s 63.3s
Average time for minikube: 64.1s

Times for Minikube (PR 9263): 61.3s 59.8s 62.3s
Average time for Minikube (PR 9263): 61.2s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9263) |
+--------------------------------+----------+--------------------+
| * minikube v1.13.0 on Debian   | 0.1s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the kvm2 driver based  | 0.0s     | 0.0s               |
| on user configuration          |          |                    |
| * Starting control plane node  | 0.0s     | 0.0s               |
| minikube in cluster minikube   |          |                    |
| * Creating kvm2 VM (CPUs=2,    | 36.4s    | 35.2s              |
| Memory=3700MB, Disk=20000MB)   |          |                    |
| ...                            |          |                    |
| * Preparing Kubernetes v1.19.1 | 25.0s    | 23.6s              |
| on Docker 19.03.12 ...         |          |                    |
| * Verifying Kubernetes         | 2.0s     | 1.7s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.6s     | 0.5s               |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
|                                | 0.0s     | 0.0s               |
| * Want kubectl v1.19.1? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

docker Driver
Times for minikube: 31.0s 29.9s 29.9s
Average time for minikube: 30.3s

Times for Minikube (PR 9263): 31.8s 30.4s 33.5s
Average time for Minikube (PR 9263): 31.9s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9263) |
+--------------------------------+----------+--------------------+
| * minikube v1.13.0 on Debian   | 0.1s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the docker driver      | 0.2s     | 0.2s               |
| based on user configuration    |          |                    |
| * Starting control plane node  | 0.1s     | 0.1s               |
| minikube in cluster minikube   |          |                    |
| * Creating docker container    | 9.1s     | 9.8s               |
| (CPUs=2, Memory=3700MB) ...    |          |                    |
| * Preparing Kubernetes v1.19.1 | 19.5s    | 20.5s              |
| on Docker 19.03.8 ...          |          |                    |
| * Verifying Kubernetes         | 1.1s     | 1.1s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.1s     | 0.1s               |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
|                                | 0.0s     | 0.0s               |
| * Want kubectl v1.19.1? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

fix mounting for docker driver in windows

6e9b1b7

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 16, 2020

k8s-ci-robot requested review from josedonizetti and priyawadhwa September 16, 2020 22:00

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2020

simplify append

14a5b0b

simplify more

4a004dd

tstromberg suggested changes Sep 17, 2020

View reviewed changes

pkg/drivers/kic/oci/types.go Outdated Show resolved Hide resolved

sharifelgamal added 4 commits September 17, 2020 11:12

Merge branch 'master' of github.com:kubernetes/minikube into windows-…

23e7989

…mount

check for windows style pathing with a regex

39ae4fb

unit tests

84ee6d3

actually add unit tests

3cb6ba0

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 17, 2020

sharifelgamal added 2 commits September 17, 2020 13:18

dates

775e047

dates, take two

f097a0d

sharifelgamal requested a review from tstromberg September 17, 2020 20:43

sharifelgamal added 4 commits September 17, 2020 16:07

Merge branch 'master' of github.com:kubernetes/minikube into windows-…

cf0e99a

…mount

try to fix functional macos test

86de364

get docker working on macos machine

f3dec28

more docker stuff

0d1ea6a

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 18, 2020

revert gh action changes

319e870

medyagh approved these changes Sep 18, 2020

View reviewed changes

revert gh pr yml change

286e1b6

kubernetes deleted a comment from minikube-pr-bot Sep 18, 2020

sharifelgamal merged commit 4d0d962 into kubernetes:master Sep 18, 2020

fmotrifork mentioned this pull request Sep 22, 2020

minikube 1.13.1 fishworks/fish-food#976

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix mounting for docker driver in windows #9263

fix mounting for docker driver in windows #9263

sharifelgamal commented Sep 16, 2020 •

edited

Loading

k8s-ci-robot commented Sep 16, 2020

TravisBuddy commented Sep 16, 2020

TravisBuddy commented Sep 16, 2020

TravisBuddy commented Sep 16, 2020

sharifelgamal commented Sep 18, 2020

minikube-pr-bot commented Sep 18, 2020

fix mounting for docker driver in windows #9263

fix mounting for docker driver in windows #9263

Conversation

sharifelgamal commented Sep 16, 2020 • edited Loading

k8s-ci-robot commented Sep 16, 2020

TravisBuddy commented Sep 16, 2020

Travis tests have failed

1st Build

TravisBuddy Request Identifier: a4dee620-f868-11ea-8f9f-a900ee46d44b

TravisBuddy commented Sep 16, 2020

Travis tests have failed

1st Build

TravisBuddy Request Identifier: f324ce90-f871-11ea-8f9f-a900ee46d44b

TravisBuddy commented Sep 16, 2020

Travis tests have failed

1st Build

TravisBuddy Request Identifier: cee2c960-f876-11ea-8f9f-a900ee46d44b

sharifelgamal commented Sep 18, 2020

minikube-pr-bot commented Sep 18, 2020

sharifelgamal commented Sep 16, 2020 •

edited

Loading