added warning for changing mount configuration with KiC driver on exsting cluster #9172
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
Hi @Asarew. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-ok-to-test
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Asarew The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Can one of the admins verify this patch? |
|
/assign @tstromberg |
|
/assign @josedonizetti |
| mount := viper.GetString(mountString) | ||
| if len(existing.ContainerVolumeMounts) != 1 || existing.ContainerVolumeMounts[0] != mount { | ||
| out.WarningT("Due to the limitations of {{.driver}}, it's not possible to the change mount configuration of an existing cluster.", out.V{"driver": existing.Driver}) | ||
| out.WarningT("If necessary delete and recreate the cluster, proceeding with old mount configuration") |
There was a problem hiding this comment.
This should exit rather than ignoring the user. Maybe something like:
exit.Error(reason.GuestMountConflict, "Sorry, {{.driver}} does not allow mounts to be changed after container creation (previous mount: {{.previous}}, new mount: {{.new}})")
(You would need to add a GuestMountConflict reason, but it shouldn't be too difficult to do so)
|
Merging as we should have this warning for this release, though we should continue to improve upon it. Tested locally, works great! |
This PR prints a warning when changing the mount configuration on an existing cluster when using either Docker or podman.
As discussed in #8159 (comment)